From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D0119ECAAD8 for ; Fri, 16 Sep 2022 13:09:39 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id A00CF3CAC83 for ; Fri, 16 Sep 2022 15:09:37 +0200 (CEST) Received: from in-6.smtp.seeweb.it (in-6.smtp.seeweb.it [IPv6:2001:4b78:1:20::6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 335003CAC18 for ; Fri, 16 Sep 2022 15:09:26 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-6.smtp.seeweb.it (Postfix) with ESMTPS id 783B81402F9C for ; Fri, 16 Sep 2022 15:09:25 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 557781F9CC; Fri, 16 Sep 2022 13:09:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1663333765; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7lzDhwp40Ln56DpZvuavQ+2kb9Z9x6mrTttZ1+nKeow=; b=1zKhQjdrOwkjXh0y3UgVADk/Ln0ydvJLfvl+8/+iK1NYOPX4ZNCtyNjQ+f5jU/EfCIgjQ6 rnn5ONlCcJYcjkbB+9o9nbP3zf52hHO8TLIlyq+Rl4LASjtbry8IPfde8ntiiBECOk9zG3 TR4NucKOGHQ7L9Oym3JruBZ26aXxPuQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1663333765; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7lzDhwp40Ln56DpZvuavQ+2kb9Z9x6mrTttZ1+nKeow=; b=iuKopeJxsrrrlDmvfEtSqsKZjnQxIc5CrRiA68gFKtMbBVlBTwrSKH4FBx6QdMgaeglkBU KT17aFl8p+37c2AA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 37A971346B; Fri, 16 Sep 2022 13:09:25 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id olInC4V1JGNiOQAAMHmgww (envelope-from ); Fri, 16 Sep 2022 13:09:25 +0000 Date: Fri, 16 Sep 2022 15:11:22 +0200 From: Cyril Hrubis To: Petr Vorel Message-ID: References: <20220915093639.2261-1-pvorel@suse.cz> <20220915093639.2261-9-pvorel@suse.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Virus-Scanned: clamav-milter 0.102.4 at in-6.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v6 8/8] df01.sh: Convert to TST_ALL_FILESYSTEMS=1 X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Palethorpe , ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! > > +TST_ALL_FILESYSTEMS=1 > > TST_CNT=12 > > TST_SETUP=setup > > TST_TESTFUNC=test > > -TST_OPTS="f:" > > -TST_USAGE=usage > > -TST_PARSE_ARGS=parse_args > > TST_NEEDS_ROOT=1 > > -TST_MOUNT_DEVICE=1 > > Just looking at this made me realize that for C API ALL_FILESYTEMST does > not imply TST_MOUNT_DEVICE since these functionalities are orthogonal. I > think that it would be better if we had the C API and shell API as close > as possible, hence ALL_FILESYSTEMS should imply only NEEDS_DEVICE and > the MOUNT_DEVICE would stay here. Also with that change: Reviewed-by: Cyril Hrubis -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp