From: Cyril Hrubis <chrubis@suse.cz>
To: Petr Vorel <pvorel@suse.cz>
Cc: Richard Palethorpe <rpalethorpe@suse.com>, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 1/1] checkpatch: Ignore warnings irrelevant in userspace
Date: Fri, 16 Sep 2022 16:08:24 +0200 [thread overview]
Message-ID: <YySDWP9I46TDIgEK@yuki> (raw)
In-Reply-To: <20220906054612.9790-1-pvorel@suse.cz>
Hi!
> * EMBEDDED_FILENAME
> fanotify.h:15: WARNING: It's generally not useful to have the filename in the file
> on #include <sys/fanotify.h> in fanotify.h
>
> * ENOSYS
> fanotify.h:26: WARNING: ENOSYS means 'invalid syscall nr' and nothing else
> on if (errno == ENOSYS)
>
> * NEW_TYPEDEFS
> fanotify.h:180: WARNING: do not add new typedefs
> on typedef struct {
I'm not 100% sure about the NEW_TYPEDEFS check, that one is mostly
right. The later two are fine.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-09-16 14:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-06 5:46 [LTP] [PATCH 1/1] checkpatch: Ignore warnings irrelevant in userspace Petr Vorel
2022-09-16 14:08 ` Cyril Hrubis [this message]
2022-09-16 19:04 ` Petr Vorel
2022-09-19 7:49 ` Cyril Hrubis
2022-09-21 11:22 ` Petr Vorel
2022-10-17 10:41 ` Richard Palethorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YySDWP9I46TDIgEK@yuki \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
--cc=rpalethorpe@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox