From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DEDD8ECAAA1 for ; Fri, 16 Sep 2022 20:39:42 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 951053CACB3 for ; Fri, 16 Sep 2022 22:39:40 +0200 (CEST) Received: from in-5.smtp.seeweb.it (in-5.smtp.seeweb.it [217.194.8.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id C8EF03CAC64 for ; Fri, 16 Sep 2022 22:39:30 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-5.smtp.seeweb.it (Postfix) with ESMTPS id 2768C60067E for ; Fri, 16 Sep 2022 22:39:29 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 9E10D1F9FD; Fri, 16 Sep 2022 20:39:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1663360768; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hJKDd3bQ+ovWBZ9GGzi00ow4aELP6Vwmnb1A4iyJDzM=; b=B5/dEZvJTpLgGlRizVE/oVpwXG7eiT3JINyvMJkGQ76Pdu+4sLIexVJEAf5UHcii2I+hS2 0S85S53u1glAtzgbVOeJYfZyL0IT3CdWQHoO+9N7HuHzpX3sJph0ZVikfKD+YNLeiB4ZB3 cE5sUALelCvqr1Aax4aAatl4qBf5WP4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1663360768; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hJKDd3bQ+ovWBZ9GGzi00ow4aELP6Vwmnb1A4iyJDzM=; b=DgeUKEdDH+s++9/3sM5iH6La7/eP/gKNmFWU1XfajrIXW4lhA+/c8RNSruFzCHd0rWKz0n fNOSs49YfUrK3TAA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6FF771346B; Fri, 16 Sep 2022 20:39:28 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id lE5qGQDfJGMOUwAAMHmgww (envelope-from ); Fri, 16 Sep 2022 20:39:28 +0000 Date: Fri, 16 Sep 2022 22:39:26 +0200 From: Petr Vorel To: Cyril Hrubis Message-ID: References: <20220915093639.2261-1-pvorel@suse.cz> <20220915093639.2261-9-pvorel@suse.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Virus-Scanned: clamav-milter 0.102.4 at in-5.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v6 8/8] df01.sh: Convert to TST_ALL_FILESYSTEMS=1 X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Cc: Richard Palethorpe , ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" > Hi! > > > +TST_ALL_FILESYSTEMS=1 > > > TST_CNT=12 > > > TST_SETUP=setup > > > TST_TESTFUNC=test > > > -TST_OPTS="f:" > > > -TST_USAGE=usage > > > -TST_PARSE_ARGS=parse_args > > > TST_NEEDS_ROOT=1 > > > -TST_MOUNT_DEVICE=1 > > Just looking at this made me realize that for C API ALL_FILESYTEMST does > > not imply TST_MOUNT_DEVICE since these functionalities are orthogonal. I > > think that it would be better if we had the C API and shell API as close > > as possible, hence ALL_FILESYSTEMS should imply only NEEDS_DEVICE and > > the MOUNT_DEVICE would stay here. Good point, thanks! Another reason is that With ALL_FILESYSTEMS implying TST_MOUNT_DEVICE mkfs01.sh could not use ALL_FILESYSTEMS=1. Kind regards, Petr > Also with that change: > Reviewed-by: Cyril Hrubis -- Mailing list info: https://lists.linux.it/listinfo/ltp