From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 019A4C54EE9 for ; Tue, 20 Sep 2022 14:19:49 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 478B83CAD3D for ; Tue, 20 Sep 2022 16:19:47 +0200 (CEST) Received: from in-5.smtp.seeweb.it (in-5.smtp.seeweb.it [217.194.8.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 73BE33CA959 for ; Tue, 20 Sep 2022 16:19:37 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-5.smtp.seeweb.it (Postfix) with ESMTPS id E2456600790 for ; Tue, 20 Sep 2022 16:19:36 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 10C531F8A4; Tue, 20 Sep 2022 14:19:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1663683576; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BfHcffJIraFwUrTjSQY5Y50BbSTTq8el6onxnYsLg4o=; b=m80y1KlRmnwdRz0UtWkV9AHe3YOhTm898lyVxdinXC2rEjDERm894XNXvp9Kv6f8RxAScB gavZnL1FObBwbdXs25pvnx40EPmIfYbGVmyjAD0a8TNDlXUzjUx+2GAEzwF+vtJddGzWEa KcxYziX3NZGt7HLIpQ8HXZEqYfg4JoU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1663683576; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BfHcffJIraFwUrTjSQY5Y50BbSTTq8el6onxnYsLg4o=; b=Po82qiGzFkja+oEDP0x+obQjasJrH8jOWvGM8LqF46TaQBsJ1Bd0110kdtZKUlKouOVQUA EUiIeuO8H7gzdjAQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id EC57F1346B; Tue, 20 Sep 2022 14:19:35 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id DiWBNvfLKWP5EQAAMHmgww (envelope-from ); Tue, 20 Sep 2022 14:19:35 +0000 Date: Tue, 20 Sep 2022 16:21:33 +0200 From: Cyril Hrubis To: Li Wang Message-ID: References: <20220915031020.2633347-1-liwang@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Virus-Scanned: clamav-milter 0.102.4 at in-5.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH] open04: add EMFILE check X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: LTP List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! > >> > > I faintly remmeber a similar patch where we decided not to work around > >> > > for a test harness leaking filedescriptors into testcases. > >> > > > >> > > >> > This also should be a solution, I searched the mailing list and got a > >> > patch[1]. > >> > Do you mean adding that close-on-exec flag when opening fd in harness? > >> > >> Yes, that way you can be sure that no file descriptors are leaked to the > >> tests. > >> > > > > Ok, should I send patch v2 like this below? > > > > Note: the automation test open04 got passed but I'm not sure > > if this has a side effect on logs. But from my observation, some > > tests (with old-API) log can't be collected anymore. > > > > Seems we shouldn't fix by adding 'close-on-exec' flag simply, > it brings more issues to some old-API tests, I'm still looking into > the problems which look like caused by ltp-pan designed. Sound strange, what is the problem here. > So can we just merge the patch as the original? Sounds sensible for the release, feel free to add: Reviewed-by: Cyril Hrubis -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp