public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Martin Doucha <mdoucha@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] tst_supported_fs: Implement checking paths against skiplist
Date: Thu, 22 Sep 2022 22:26:14 +0200	[thread overview]
Message-ID: <YyzE5veC2ifakpT2@pevik> (raw)
In-Reply-To: <20220921155006.13360-1-mdoucha@suse.cz>

Hi,

> +++ b/testcases/lib/tst_supported_fs.c
...
>  	/* fs_type */
>  	if (optind < argc) {
> -		if (argv[optind][0] == '\0')
> +		if (fsname) {
> +			fprintf(stderr, "Can't specify fs_type and -d together\n");
> +			usage();
> +			return 2;
> +
nit: remove this extra line before merging.
> +		}
> +
> +		fsname = argv[optind];
> +	}
...

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  parent reply	other threads:[~2022-09-22 20:26 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-21 15:50 [LTP] [PATCH] tst_supported_fs: Implement checking paths against skiplist Martin Doucha
2022-09-22  4:16 ` Li Wang
2022-09-22  8:14   ` Martin Doucha
2022-09-22  8:43     ` Petr Vorel
2022-09-22  9:08       ` Li Wang
2022-09-22  9:56         ` Petr Vorel
2022-09-22  9:02   ` Petr Vorel
2022-09-22  9:24     ` Li Wang
2022-09-22 10:40       ` Petr Vorel
2022-09-22 10:55         ` Cyril Hrubis
2022-09-22 10:57           ` Martin Doucha
2022-09-22 11:20             ` Petr Vorel
2022-09-22 14:42               ` Cyril Hrubis
2022-09-22 20:22                 ` Petr Vorel
2022-09-22  8:56 ` Petr Vorel
2022-09-22 20:26 ` Petr Vorel [this message]
2022-09-23 10:00 ` Petr Vorel
2022-09-26  7:48   ` Petr Vorel
2022-09-23 15:17 ` Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YyzE5veC2ifakpT2@pevik \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    --cc=mdoucha@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox