public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: Edward Liaw <edliaw@google.com>
Cc: kernel-team@android.com, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v3 9/9] mmapstress01: reorder vars and functions
Date: Wed, 5 Oct 2022 12:21:27 +0200	[thread overview]
Message-ID: <Yz1apwbYCuUkLotX@yuki> (raw)
In-Reply-To: <20221004182040.1859774-10-edliaw@google.com>

Hi!
> diff --git a/testcases/kernel/mem/mmapstress/mmapstress01.c b/testcases/kernel/mem/mmapstress/mmapstress01.c
> index 9eced3526..f68193706 100644
> --- a/testcases/kernel/mem/mmapstress/mmapstress01.c
> +++ b/testcases/kernel/mem/mmapstress/mmapstress01.c
> @@ -72,26 +72,27 @@
>  #define roundup(x, y)	((((x)+((y)-1))/(y))*(y))
>  
>  static unsigned int initrand(void);
> -static void finish(int sig);
>  static void child_mapper(char *file, unsigned int procno, unsigned int nprocs);
>  static void fileokay(char *file, unsigned char *expbuf);
> +static void sighandler(int sig);

Most of these can be dropped now. The only that needs to stay is
initrand().

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2022-10-05 10:19 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-04 18:20 [LTP] [PATCH v3 0/9] mmapstress01: refactor to ltp framework Edward Liaw via ltp
2022-10-04 18:20 ` [LTP] [PATCH v3 1/9] mmapstress01: refactor to tst_test framework Edward Liaw via ltp
2022-10-04 18:20 ` [LTP] [PATCH v3 2/9] mmapstress01: apply make check suggestions Edward Liaw via ltp
2022-10-04 18:20 ` [LTP] [PATCH v3 3/9] mmapstress01: refactor options Edward Liaw via ltp
2022-10-04 18:20 ` [LTP] [PATCH v3 4/9] mmapstress01: use FILE_OFFSET_BITS=64 Edward Liaw via ltp
2022-10-04 18:20 ` [LTP] [PATCH v3 5/9] mmapstress01: use safe macros Edward Liaw via ltp
2022-10-04 18:20 ` [LTP] [PATCH v3 6/9] mmapstress01: refactor cleanup and drop leavefile option Edward Liaw via ltp
2022-10-04 18:20 ` [LTP] [PATCH v3 7/9] mmapstress01: use SAFE_FORK Edward Liaw via ltp
2022-10-04 18:20 ` [LTP] [PATCH v3 8/9] mmapstress01: update license Edward Liaw via ltp
2022-10-04 18:20 ` [LTP] [PATCH v3 9/9] mmapstress01: reorder vars and functions Edward Liaw via ltp
2022-10-05 10:21   ` Cyril Hrubis [this message]
2022-10-05 10:31 ` [LTP] [PATCH v3 0/9] mmapstress01: refactor to ltp framework Cyril Hrubis
2022-10-05 11:22   ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yz1apwbYCuUkLotX@yuki \
    --to=chrubis@suse.cz \
    --cc=edliaw@google.com \
    --cc=kernel-team@android.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox