From: Cyril Hrubis <chrubis@suse.cz>
To: Edward Liaw <edliaw@google.com>
Cc: kernel-team@android.com, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v3 0/9] mmapstress01: refactor to ltp framework
Date: Wed, 5 Oct 2022 12:31:13 +0200 [thread overview]
Message-ID: <Yz1c8XAKPmNkaFYn@yuki> (raw)
In-Reply-To: <20221004182040.1859774-1-edliaw@google.com>
Hi!
The code is heading into the right direction but there are couple of
things to do (can be done in an incremental manner too):
* Most of the remaning tst_brk(TFAIL, "..") should actually be
tst_brk(TBROK, "..") at least all the cases where we call
a syscall and it fails. And we should include the TERRNO flag
as well to get the actual error printed.
* The test should make use of runtime instead of the alarm()
for test duration. That would mean getting rid of the -t option and
using the -I option instead. Also the test should set up some
.test_runtime for a default run duration in the tst_test structure.
* The top level comment has to be updated for the changes in the test
since the options structure describes the command line parameters
quite well I would just remove that part from the comment
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-10-05 10:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-04 18:20 [LTP] [PATCH v3 0/9] mmapstress01: refactor to ltp framework Edward Liaw via ltp
2022-10-04 18:20 ` [LTP] [PATCH v3 1/9] mmapstress01: refactor to tst_test framework Edward Liaw via ltp
2022-10-04 18:20 ` [LTP] [PATCH v3 2/9] mmapstress01: apply make check suggestions Edward Liaw via ltp
2022-10-04 18:20 ` [LTP] [PATCH v3 3/9] mmapstress01: refactor options Edward Liaw via ltp
2022-10-04 18:20 ` [LTP] [PATCH v3 4/9] mmapstress01: use FILE_OFFSET_BITS=64 Edward Liaw via ltp
2022-10-04 18:20 ` [LTP] [PATCH v3 5/9] mmapstress01: use safe macros Edward Liaw via ltp
2022-10-04 18:20 ` [LTP] [PATCH v3 6/9] mmapstress01: refactor cleanup and drop leavefile option Edward Liaw via ltp
2022-10-04 18:20 ` [LTP] [PATCH v3 7/9] mmapstress01: use SAFE_FORK Edward Liaw via ltp
2022-10-04 18:20 ` [LTP] [PATCH v3 8/9] mmapstress01: update license Edward Liaw via ltp
2022-10-04 18:20 ` [LTP] [PATCH v3 9/9] mmapstress01: reorder vars and functions Edward Liaw via ltp
2022-10-05 10:21 ` Cyril Hrubis
2022-10-05 10:31 ` Cyril Hrubis [this message]
2022-10-05 11:22 ` [LTP] [PATCH v3 0/9] mmapstress01: refactor to ltp framework Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yz1c8XAKPmNkaFYn@yuki \
--to=chrubis@suse.cz \
--cc=edliaw@google.com \
--cc=kernel-team@android.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox