Re: [LTP] [PATCH v7 2/2] cpuset_memory_testset.sh: Remove test6

Wei Gao via ltp
2025-03-25T03:55:17Z

Hi Petr

Got it, currently the reason for previous commit change is v6's comments
from Cyril.

v6:
https://patchwork.ozlabs.org/project/ltp/patch/20250305050805.7905-2-wegao@suse.com/
Changes v6-v7:
* select node from nodemap which got in setup()
* remove unnecessary step such as locking process to node0 and
schedu_load_balance setting
* change allocate memory to single page
* remove checkpoint

Thanks.
Regards
Gao Wei

On Tue, Mar 25, 2025 at 11:32 AM Wei Gao <wegao@suse.com> wrote:

> On Mon, Mar 24, 2025 at 04:32:52PM +0100, Petr Vorel wrote:
> > Hi Wei,
> >
> > it's helpful in the commit message to write *the reason* why doing
> change.
> > There should be a note that C test in the previous commit implemented
> the test.
> >
> Got it, the previous commit change mainly base Cyril v6's feedback.
> > Also generally it helps a review process if you add a changelog what
> changed in
> > the previous version.
> Thanks for point this out.
>
> v6:
> https://patchwork.ozlabs.org/project/ltp/patch/20250305050805.7905-2-wegao@suse.com/
> Changes v6-v7:
> * choose a node from the nodemap which get from setup instead of using
> hardcode node0
> * remove unnecessary steps such as locking process into specific node and
> sched_load_balance
> * update allocate memory size to single page
> * remove unnecessary checkpoints
>
>
> >
> > Kind regards,
> > Petr
>