[LTP] [PATCH] doc: correct the build steps for open_posix_testsuite

[LTP] [PATCH] doc: correct the build steps for open_posix_testsuite

[xiubli]

From: Xiubo Li <xiubli@redhat.com>

'./configure' is needed just before generating the Makefiles.

Signed-off-by: Xiubo Li <xiubli@redhat.com>
---
 doc/users/quick_start.rst | 1 +
 1 file changed, 1 insertion(+)

diff --git a/doc/users/quick_start.rst b/doc/users/quick_start.rst
index 1581b1f0c..e80c1c244 100644
--- a/doc/users/quick_start.rst
+++ b/doc/users/quick_start.rst
@@ -54,6 +54,7 @@ generated first:
 .. code-block:: console
 
    $ cd testcases/open_posix_testsuite/
+   $ ./configure
    $ make generate-makefiles
    $ cd conformance/interfaces/foo
    $ make
-- 
2.46.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] doc: correct the build steps for open_posix_testsuite

[Cyril Hrubis]

Hi!
> './configure' is needed just before generating the Makefiles.
> 
> Signed-off-by: Xiubo Li <xiubli@redhat.com>
> ---
>  doc/users/quick_start.rst | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/doc/users/quick_start.rst b/doc/users/quick_start.rst
> index 1581b1f0c..e80c1c244 100644
> --- a/doc/users/quick_start.rst
> +++ b/doc/users/quick_start.rst
> @@ -54,6 +54,7 @@ generated first:
>  .. code-block:: console
>  
>     $ cd testcases/open_posix_testsuite/
> +   $ ./configure

That should be before the 'cd testcase/...' otherwise good catch, this
is clearly missing there.

>     $ make generate-makefiles
>     $ cd conformance/interfaces/foo
>     $ make
> -- 
> 2.46.0
> 
> 
> -- 
> Mailing list info: https://lists.linux.it/listinfo/ltp

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] doc: correct the build steps for open_posix_testsuite

[Xiubo Li]

On 11/29/24 18:27, Cyril Hrubis wrote:
> Hi!
>> './configure' is needed just before generating the Makefiles.
>>
>> Signed-off-by: Xiubo Li <xiubli@redhat.com>
>> ---
>>   doc/users/quick_start.rst | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/doc/users/quick_start.rst b/doc/users/quick_start.rst
>> index 1581b1f0c..e80c1c244 100644
>> --- a/doc/users/quick_start.rst
>> +++ b/doc/users/quick_start.rst
>> @@ -54,6 +54,7 @@ generated first:
>>   .. code-block:: console
>>   
>>      $ cd testcases/open_posix_testsuite/
>> +   $ ./configure
> That should be before the 'cd testcase/...' otherwise good catch, this
> is clearly missing there.

Good catch.

Fixed it.

Thanks!


>>      $ make generate-makefiles
>>      $ cd conformance/interfaces/foo
>>      $ make
>> -- 
>> 2.46.0
>>
>>
>> -- 
>> Mailing list info: https://lists.linux.it/listinfo/ltp


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] doc: correct the build steps for open_posix_testsuite

[Xiubo Li]

On 11/29/24 18:27, Cyril Hrubis wrote:
> Hi!
>> './configure' is needed just before generating the Makefiles.
>>
>> Signed-off-by: Xiubo Li<xiubli@redhat.com>
>> ---
>>   doc/users/quick_start.rst | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/doc/users/quick_start.rst b/doc/users/quick_start.rst
>> index 1581b1f0c..e80c1c244 100644
>> --- a/doc/users/quick_start.rst
>> +++ b/doc/users/quick_start.rst
>> @@ -54,6 +54,7 @@ generated first:
>>   .. code-block:: console
>>   
>>      $ cd testcases/open_posix_testsuite/
>> +   $ ./configure
> That should be before the 'cd testcase/...' otherwise good catch, this
> is clearly missing there.

Wait.

I check it again. I think we should do it under 
'testcases/open_posix_testsuite/' too ? For me it doesn't work only do 
this just before 'cd testcase/...'

Please see:

$ cd testcases/open_posix_testsuite/ $ ls AUTHORS bin ChangeLog 
configure.ac COPYING functional Makefile QUICK-START scripts tools 
autom4te.cache BUILD configure conformance Documentation include NEWS 
README stress

The 'make generate-makefiles' will fail without running the 
`./configure` under 'testcases/open_posix_testsuite/':

$ make generate-makefiles include/mk/env.mk:8: 
/tmp/ltp/testcases/open_posix_testsuite/include/mk/config.mk: No such 
file or directory make: *** No rule to make target 
'/tmp/ltp/testcases/open_posix_testsuite/include/mk/config.mk'. Stop.

Run then './configure' first and then run to generate the makefiles it 
will succeed:

$ ./configure checking for gcc... gcc checking whether the C compiler 
works... yes checking for C compiler default output file name... a.out 
checking for suffix of executables... checking whether we are cross 
compiling... no checking for suffix of object files... o checking 
whether the compiler supports GNU C... yes checking whether gcc accepts 
-g... yes checking for gcc option to enable C11 features... none needed 
configure: creating ./config.status config.status: creating 
include/mk/config.mk

$ make generate-makefiles make[1]: Entering directory 
'/tmp/ltp/testcases/open_posix_testsuite/conformance' make[2]: Entering 
directory '/tmp/ltp/testcases/open_posix_testsuite/conformance/behavior' 
make[2]: Leaving directory 
'/tmp/ltp/testcases/open_posix_testsuite/conformance/behavior' make[2]: 
Entering directory 
'/tmp/ltp/testcases/open_posix_testsuite/conformance/definitions' 
make[2]: Leaving directory 
'/tmp/ltp/testcases/open_posix_testsuite/conformance/definitions' 
make[2]: Entering directory 
'/tmp/ltp/testcases/open_posix_testsuite/conformance/interfaces' 
make[2]: Leaving directory 
'/tmp/ltp/testcases/open_posix_testsuite/conformance/interfaces' 
make[1]: Leaving directory 
'/tmp/ltp/testcases/open_posix_testsuite/conformance' make[1]: Entering 
directory '/tmp/ltp/testcases/open_posix_testsuite/functional' make[1]: 
Leaving directory '/tmp/ltp/testcases/open_posix_testsuite/functional' 
make[1]: Entering directory 
'/tmp/ltp/testcases/open_posix_testsuite/stress' make[1]: Leaving 
directory '/tmp/ltp/testcases/open_posix_testsuite/stress' Generating 
buildonly Makefiles Generating runnable Makefiles

>>      $ make generate-makefiles
>>      $ cd conformance/interfaces/foo
>>      $ make
>> -- 
>> 2.46.0
>>
>>
>> -- 
>> Mailing list info:https://lists.linux.it/listinfo/ltp

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] doc: correct the build steps for open_posix_testsuite

[Cyril Hrubis]

Hi!
> Wait.
> 
> I check it again. I think we should do it under 
> 'testcases/open_posix_testsuite/' too ? For me it doesn't work only do 
> this just before 'cd testcase/...'

Ah it's a bit more complicated that I remmebered. There are two ways how
to compile the open posix testsuite.

The top level configure script configures the open posix testsuite, but
you have to pass the --with-open-posix-testsuite flag to it.

Or you can run the open posix configure from the open posix directory.

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] doc: correct the build steps for open_posix_testsuite

[Xiubo Li]

On 12/2/24 18:43, Cyril Hrubis wrote:
> Hi!
>> Wait.
>>
>> I check it again. I think we should do it under
>> 'testcases/open_posix_testsuite/' too ? For me it doesn't work only do
>> this just before 'cd testcase/...'
> Ah it's a bit more complicated that I remmebered. There are two ways how
> to compile the open posix testsuite.
>
> The top level configure script configures the open posix testsuite, but
> you have to pass the --with-open-posix-testsuite flag to it.
>
> Or you can run the open posix configure from the open posix directory.
>
Yeah, this looks better.

Does it make sense to fix the doc about this ? If so I will send the V3.

Thanks

- Xiubo


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] doc: correct the build steps for open_posix_testsuite

[Cyril Hrubis]

Hi!
> > The top level configure script configures the open posix testsuite, but
> > you have to pass the --with-open-posix-testsuite flag to it.
> >
> > Or you can run the open posix configure from the open posix directory.
> >
> Yeah, this looks better.
> 
> Does it make sense to fix the doc about this ? If so I will send the V3.

Yes please (and sorry for the delayed response).

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] doc: correct the build steps for open_posix_testsuite

[Xiubo Li]

On 12/10/24 20:15, Cyril Hrubis wrote:
> Hi!
>>> The top level configure script configures the open posix testsuite, but
>>> you have to pass the --with-open-posix-testsuite flag to it.
>>>
>>> Or you can run the open posix configure from the open posix directory.
>>>
>> Yeah, this looks better.
>>
>> Does it make sense to fix the doc about this ? If so I will send the V3.
> Yes please (and sorry for the delayed response).
>
Done. Thanks!


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp