From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6E259E77197 for ; Tue, 7 Jan 2025 16:15:36 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id B32553C1483 for ; Tue, 7 Jan 2025 17:15:34 +0100 (CET) Received: from in-2.smtp.seeweb.it (in-2.smtp.seeweb.it [217.194.8.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id D61793C01D3 for ; Tue, 7 Jan 2025 17:15:18 +0100 (CET) Authentication-Results: in-2.smtp.seeweb.it; spf=pass (sender SPF authorized) smtp.mailfrom=suse.cz (client-ip=195.135.223.130; helo=smtp-out1.suse.de; envelope-from=chrubis@suse.cz; receiver=lists.linux.it) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-2.smtp.seeweb.it (Postfix) with ESMTPS id 723EC656FF7 for ; Tue, 7 Jan 2025 17:15:18 +0100 (CET) Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 97ED3210F8; Tue, 7 Jan 2025 16:15:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1736266517; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iriFT9typZaRnLhKjT2XNrZnG2EmQ7og9RA5cE5+Nfw=; b=JENWgfxCLriHpLhpjfMLb/TOtWjISU/Bw9rZnxL2cYT/L96t+M2wEnMelvKrJLGGjvZJ1o RhZXbMtxyDE8Y2DCkteJwpj2XVh2JRTiFoaNgzD81OqKyqBbfj9d7HFied+M5VGqYSa/l6 q4mMLmk342HrDOxMgjedh8oyW1xR62c= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1736266517; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iriFT9typZaRnLhKjT2XNrZnG2EmQ7og9RA5cE5+Nfw=; b=SbhSSOizrjQfv311hvz8oHQ4I0fkqqkHgIWwV25S/0KcsOvK/ng47o+Cjo755sZrshvWBu a6iQIPKDVj2s/yCA== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1736266517; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iriFT9typZaRnLhKjT2XNrZnG2EmQ7og9RA5cE5+Nfw=; b=JENWgfxCLriHpLhpjfMLb/TOtWjISU/Bw9rZnxL2cYT/L96t+M2wEnMelvKrJLGGjvZJ1o RhZXbMtxyDE8Y2DCkteJwpj2XVh2JRTiFoaNgzD81OqKyqBbfj9d7HFied+M5VGqYSa/l6 q4mMLmk342HrDOxMgjedh8oyW1xR62c= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1736266517; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iriFT9typZaRnLhKjT2XNrZnG2EmQ7og9RA5cE5+Nfw=; b=SbhSSOizrjQfv311hvz8oHQ4I0fkqqkHgIWwV25S/0KcsOvK/ng47o+Cjo755sZrshvWBu a6iQIPKDVj2s/yCA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 852AE13A6A; Tue, 7 Jan 2025 16:15:17 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id Ta4nIBVTfWe5WQAAD6G6ig (envelope-from ); Tue, 07 Jan 2025 16:15:17 +0000 Date: Tue, 7 Jan 2025 17:14:55 +0100 From: Cyril Hrubis To: Andrea Cervesato Message-ID: References: <20250106-fix_setsid_tests-v2-0-c43f57a2bab6@suse.com> <20250106-fix_setsid_tests-v2-4-c43f57a2bab6@suse.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250106-fix_setsid_tests-v2-4-c43f57a2bab6@suse.com> X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.999]; MIME_GOOD(-0.10)[text/plain]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MISSING_XM_UA(0.00)[]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo] X-Virus-Scanned: clamav-milter 1.0.3 at in-2.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v2 04/11] Add ptem02 test X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! The same here: - TST_EXP_PASS() vs TST_EXP_POSSITIVE() - possibly initialize the pts in test setup()? Also if you are going to initialize the masterfd in each test it may make sense to put that code into a function in a header and include that in each test. -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp