public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 3/7] Add lsm_get_self_attr02 test
Date: Wed, 8 Jan 2025 14:35:12 +0100	[thread overview]
Message-ID: <Z35_EDf-np4R0AeT@yuki.lan> (raw)
In-Reply-To: <Z352WrLF5bP-DgA2@rei>

Hi!
> > +static void setup(void)
> > +{
> > +	page_size = SAFE_SYSCONF(_SC_PAGESIZE);
> > +
> > +	if (verify_enabled_lsm("selinux"))
> > +		lsm_count++;
> > +
> > +	if (verify_enabled_lsm("apparmor"))
> > +		lsm_count++;
> > +
> > +	if (verify_enabled_lsm("smack"))
> > +		lsm_count++;
> 
> Shouldn't we just look at the /sys/kernel/security/lsm file and if it
> exists and it's not empty there is a lsm on the system and the syscall
> will not fail in that case?

And looking into the documentation these attributes are currently
supported only by these three lsms. So this is correct, however the
pattern is repeated in other tests, so maybe put it into a inline
function into a common header?

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  parent reply	other threads:[~2025-01-08 13:35 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-12  7:15 [LTP] [PATCH 0/7] LSM testing suite Andrea Cervesato
2024-11-12  7:15 ` [LTP] [PATCH 1/7] Add fallback definitions of LSM syscalls Andrea Cervesato
2024-11-12  8:26   ` Wei Gao via ltp
2024-11-13 23:11     ` Petr Vorel
2024-11-14  1:55       ` Wei Gao via ltp
2024-12-18 18:24   ` Petr Vorel
2024-11-12  7:15 ` [LTP] [PATCH 2/7] Add lsm_get_self_attr01 test Andrea Cervesato
2024-12-18 18:55   ` Petr Vorel
2025-01-07  8:50     ` Andrea Cervesato via ltp
2025-01-08  8:53     ` Andrea Cervesato via ltp
2025-01-08 12:52   ` Cyril Hrubis
2024-11-12  7:15 ` [LTP] [PATCH 3/7] Add lsm_get_self_attr02 test Andrea Cervesato
2025-01-08 12:58   ` Cyril Hrubis
2025-01-08 13:13     ` Andrea Cervesato via ltp
2025-01-08 13:35     ` Cyril Hrubis [this message]
2024-11-12  7:15 ` [LTP] [PATCH 4/7] Add lsm_get_self_attr03 test Andrea Cervesato
2024-11-12  7:15 ` [LTP] [PATCH 5/7] Add lsm_list_modules01 test Andrea Cervesato
2025-01-08 13:49   ` Cyril Hrubis
2024-11-12  7:15 ` [LTP] [PATCH 6/7] Add lsm_list_modules02 test Andrea Cervesato
2025-01-08 14:05   ` Cyril Hrubis
2024-11-12  7:15 ` [LTP] [PATCH 7/7] Add lsm_set_self_attr01 test Andrea Cervesato
2024-12-18 19:03   ` Petr Vorel
2025-01-08  8:50     ` Andrea Cervesato via ltp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z35_EDf-np4R0AeT@yuki.lan \
    --to=chrubis@suse.cz \
    --cc=andrea.cervesato@suse.de \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox