public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: Li Wang <liwang@redhat.com>
Cc: ltp@lists.linux.it, Martin Doucha <martin.doucha@suse.com>
Subject: Re: [LTP] [RFC PATCh] lib: redefine the overall timeout logic of test
Date: Wed, 8 Jan 2025 13:33:28 +0100	[thread overview]
Message-ID: <Z35wmODIV_vuYBOA@rei> (raw)
In-Reply-To: <CAEemH2eAoto=mLFeiXG9WtwPgiwzF=NKbXDbE1eWTuo_QBW8Zw@mail.gmail.com>

Hi!
> > Btw, we have some tests that implicitly invoke tst_remaining_runtime,
> > for example, using the fuzzy_sync library, which also needs .runtime
> > but not .timeout.
> >
> 
> Also, tests that use 'test.runtime' directly (e.g. readahead02.c,
> set_mempolicy01.c)
> must continue to be marked as using .runtime.

I think that readahead02 is a case where we should switch to timeout
because that is exactly the situation where want the timeout to be
multiplied when the system is slower. The way the test adjust the
runtime dynamically is wrong anyways, because it increases the timeout
for each iteration. We should just put the worstcase runtime into the
.timeout instead.

And similarily for the the mempolicy it looks like we should set the
timeout dynamicaly in the testup with tst_set_timeout() instead of
runtime.

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2025-01-08 12:29 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-08  7:12 [LTP] [RFC PATCh] lib: redefine the overall timeout logic of test Li Wang
2025-01-08  9:18 ` Cyril Hrubis
2025-01-08 10:49   ` Li Wang
2025-01-08 11:37     ` Li Wang
2025-01-08 12:33       ` Cyril Hrubis [this message]
2025-01-09  6:31         ` Li Wang
2025-01-09  7:50           ` Cyril Hrubis
2025-01-09  8:42             ` Li Wang
2025-01-09  8:51               ` Li Wang
2025-01-09 10:34                 ` Cyril Hrubis
2025-01-09 10:45                   ` Li Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z35wmODIV_vuYBOA@rei \
    --to=chrubis@suse.cz \
    --cc=liwang@redhat.com \
    --cc=ltp@lists.linux.it \
    --cc=martin.doucha@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox