From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A8CFEE77199 for ; Wed, 8 Jan 2025 12:29:49 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 150663C1B93 for ; Wed, 8 Jan 2025 13:29:48 +0100 (CET) Received: from in-2.smtp.seeweb.it (in-2.smtp.seeweb.it [IPv6:2001:4b78:1:20::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 332243C1A25 for ; Wed, 8 Jan 2025 13:29:30 +0100 (CET) Authentication-Results: in-2.smtp.seeweb.it; spf=pass (sender SPF authorized) smtp.mailfrom=suse.cz (client-ip=195.135.223.130; helo=smtp-out1.suse.de; envelope-from=chrubis@suse.cz; receiver=lists.linux.it) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-2.smtp.seeweb.it (Postfix) with ESMTPS id C546A65FA41 for ; Wed, 8 Jan 2025 13:29:28 +0100 (CET) Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B80FF2111F; Wed, 8 Jan 2025 12:29:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1736339367; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XJhIJQMDbq4z5ym+Km20Bj6MPFZnrJqjKU4eXVmt4JM=; b=JC9/J//NSF7B6yLpwvw+q+Ld20ZSOtrlGzwDNSsDvwEYELAMFF9plzL7Y5aJu7HmNrcBqZ TwCWAaPDagFXo1aK++VdRJEA+3wG4ddH6cK235eimZ+fsFZUTF18WMSL5CPaKu0LdlAwyj kP1J+qc+1llzTdNWOR88G9G22BJyuSg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1736339367; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XJhIJQMDbq4z5ym+Km20Bj6MPFZnrJqjKU4eXVmt4JM=; b=EXNZA5qhdii+4q/KfyEMHV+0aj5KAzn2Y/jnf9lh9Vo2t3HjWRT7Ajh1on4dwrnJY+kDJn 1tgPzIeN797mJuAg== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="JC9/J//N"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=EXNZA5qh DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1736339367; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XJhIJQMDbq4z5ym+Km20Bj6MPFZnrJqjKU4eXVmt4JM=; b=JC9/J//NSF7B6yLpwvw+q+Ld20ZSOtrlGzwDNSsDvwEYELAMFF9plzL7Y5aJu7HmNrcBqZ TwCWAaPDagFXo1aK++VdRJEA+3wG4ddH6cK235eimZ+fsFZUTF18WMSL5CPaKu0LdlAwyj kP1J+qc+1llzTdNWOR88G9G22BJyuSg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1736339367; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XJhIJQMDbq4z5ym+Km20Bj6MPFZnrJqjKU4eXVmt4JM=; b=EXNZA5qhdii+4q/KfyEMHV+0aj5KAzn2Y/jnf9lh9Vo2t3HjWRT7Ajh1on4dwrnJY+kDJn 1tgPzIeN797mJuAg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id A5AD51351A; Wed, 8 Jan 2025 12:29:27 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id scd9JqdvfmcVIgAAD6G6ig (envelope-from ); Wed, 08 Jan 2025 12:29:27 +0000 Date: Wed, 8 Jan 2025 13:33:28 +0100 From: Cyril Hrubis To: Li Wang Message-ID: References: <20250108071201.26984-1-liwang@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: B80FF2111F X-Spamd-Result: default: False [-4.01 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_RHS_NOT_FQDN(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; ARC_NA(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.cz:+]; RCPT_COUNT_SEVEN(0.00)[7]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; ASN(0.00)[asn:25478, ipnet:::/0, country:RU]; RCVD_VIA_SMTP_AUTH(0.00)[]; MISSING_XM_UA(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.cz:dkim, suse.cz:email, imap1.dmz-prg2.suse.org:helo, imap1.dmz-prg2.suse.org:rdns] X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Action: no action X-Virus-Scanned: clamav-milter 1.0.3 at in-2.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [RFC PATCh] lib: redefine the overall timeout logic of test X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ltp@lists.linux.it, Martin Doucha Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! > > Btw, we have some tests that implicitly invoke tst_remaining_runtime, > > for example, using the fuzzy_sync library, which also needs .runtime > > but not .timeout. > > > > Also, tests that use 'test.runtime' directly (e.g. readahead02.c, > set_mempolicy01.c) > must continue to be marked as using .runtime. I think that readahead02 is a case where we should switch to timeout because that is exactly the situation where want the timeout to be multiplied when the system is slower. The way the test adjust the runtime dynamically is wrong anyways, because it increases the timeout for each iteration. We should just put the worstcase runtime into the .timeout instead. And similarily for the the mempolicy it looks like we should set the timeout dynamicaly in the testup with tst_set_timeout() instead of runtime. -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp