From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5CBD7E77197 for ; Thu, 9 Jan 2025 15:10:01 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id DB1C53C2799 for ; Thu, 9 Jan 2025 16:09:59 +0100 (CET) Received: from in-6.smtp.seeweb.it (in-6.smtp.seeweb.it [217.194.8.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 6F0D33C2653 for ; Thu, 9 Jan 2025 16:09:43 +0100 (CET) Authentication-Results: in-6.smtp.seeweb.it; spf=pass (sender SPF authorized) smtp.mailfrom=suse.cz (client-ip=195.135.223.131; helo=smtp-out2.suse.de; envelope-from=chrubis@suse.cz; receiver=lists.linux.it) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-6.smtp.seeweb.it (Postfix) with ESMTPS id 0080F140E60E for ; Thu, 9 Jan 2025 16:09:42 +0100 (CET) Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 554E51F453; Thu, 9 Jan 2025 15:09:42 +0000 (UTC) Authentication-Results: smtp-out2.suse.de; none Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 43A6D139AB; Thu, 9 Jan 2025 15:09:42 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id Q2qnD7bmf2csbQAAD6G6ig (envelope-from ); Thu, 09 Jan 2025 15:09:42 +0000 Date: Thu, 9 Jan 2025 16:09:25 +0100 From: Cyril Hrubis To: Petr Vorel Message-ID: References: <20250109142847.326936-1-pvorel@suse.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250109142847.326936-1-pvorel@suse.cz> X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 50.00]; REPLY(-4.00)[]; ASN(0.00)[asn:25478, ipnet:::/0, country:RU] X-Rspamd-Queue-Id: 554E51F453 X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Virus-Scanned: clamav-milter 1.0.3 at in-6.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH 1/1] testinfo.pl: Properly handle NULL X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! > While at it, add missing comma to the arguments. > > Fixes: 946d20bdaf ("metadata: metaparse: Better array parsing.") > Signed-off-by: Petr Vorel > --- > NOTE: if we don't want to have NULL in the docs (see e.g. hugemmap10), > we can simply filer it: That is a question on how should be the save_restore formatted in the docs. I guess that as a quick fix this is fine. Acked-by: Cyril Hrubis > $content .= paragraph(table_escape(join(', ', grep defined, @$v2))); > > docparse/testinfo.pl | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/docparse/testinfo.pl b/docparse/testinfo.pl > index 78433c40a3..487b7d5f22 100755 > --- a/docparse/testinfo.pl > +++ b/docparse/testinfo.pl > @@ -408,7 +408,11 @@ sub content_all_tests > # two dimensional array > if (ref(@$v[0]) eq 'ARRAY') { > for my $v2 (@$v) { > - $content .= paragraph(table_escape(join(' ', @$v2))); > + # convert NULL to "NULL" string to be printed > + for my $v3 (@$v2) { > + $v3 = "NULL" if (!defined $v3); > + } > + $content .= paragraph(table_escape(join(', ', @$v2))); > } > } else { > # one dimensional array > -- > 2.47.1 > -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp