[LTP] [PATCH v3 01/12] Refactor setpgid01 test

Andrea Cervesato
2025-01-09T14:13:19Z

Test used to fail when running inside an executor that is setting a
new session via setsid(). By using the new LTP library, we fix this
issue since it forks parent first, then execute it, enabling any
setsid() to be run in the main process before execution.

Fixes: https://github.com/linux-test-project/kirk/issues/28
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
Signed-off-by: Andrea Cervesato <andrea.cervesato@suse.com>
---
testcases/kernel/syscalls/setpgid/setpgid01.c | 152 +++++---------------------
1 file changed, 25 insertions(+), 127 deletions(-)

diff --git a/testcases/kernel/syscalls/setpgid/setpgid01.c b/testcases/kernel/syscalls/setpgid/setpgid01.c
index 60034e01660d5c3aebe8ca960ff64c03f2b539e5..c976c3a5138ce7bca9f92a7d624797a9f2a08154 100644
--- a/testcases/kernel/syscalls/setpgid/setpgid01.c
+++ b/testcases/kernel/syscalls/setpgid/setpgid01.c
@@ -1,150 +1,48 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
/*
* Copyright (c) 2000 Silicon Graphics, Inc. All Rights Reserved.
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of version 2 of the GNU General Public License as
- * published by the Free Software Foundation.
- *
- * This program is distributed in the hope that it would be useful, but
- * WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
- *
- * Further, this software is distributed without any warranty that it is
- * free of the rightful claim of any third person regarding infringement
- * or the like. Any license provided herein, whether implied or
- * otherwise, applies only to this software file. Patent licenses, if
- * any, provided herein do not apply to combinations of this program with
- * other software, or any other product whatsoever.
- *
- * You should have received a copy of the GNU General Public License along
- * with this program; if not, write the Free Software Foundation, Inc.,
- * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
- *
- * Contact information: Silicon Graphics, Inc., 1600 Amphitheatre Pkwy,
- * Mountain View, CA 94043, or:
- *
- * http://www.sgi.com
- *
- * For further information regarding this notice, see:
- *
- * http://oss.sgi.com/projects/GenInfo/NoticeExplan/
- *
+ * Copyright (C) 2024 SUSE LLC Andrea Cervesato <andrea.cervesato@suse.com>
*/
-/* $Id: setpgid01.c,v 1.7 2009/11/02 13:57:18 subrata_modak Exp $ */

-/*
- * Description:
- * Verify that:
- * 1. Basic functionality test for setpgid(2).
- * 2. Check functioning of setpgid(2) with pid = 0 and pgid = 0.
+/*\
+ * [Description]
+ *
+ * Verify basic setpgid() functionality, re-setting group ID inside both parent
+ * and child. In the first case, we obtain getpgrp() and set it. In the second
+ * case, we use setpgid(0, 0).
*/

-#include <errno.h>
-#include <string.h>
-#include <signal.h>
-#include <stdlib.h>
-#include <sys/wait.h>
-#include "test.h"
-
-static void setup(void);
-static void cleanup(void);
-
-char *TCID = "setpgid01";
-
-static void setpgid_test1(void);
-static void setpgid_test2(void);
-static void (*testfunc[])(void) = { setpgid_test1, setpgid_test2};
-int TST_TOTAL = ARRAY_SIZE(testfunc);
-
-int main(int ac, char **av)
-{
- int i, lc;
-
- tst_parse_opts(ac, av, NULL, NULL);
-
- setup();
-
- for (lc = 0; TEST_LOOPING(lc); lc++) {
- tst_count = 0;
-
- for (i = 0; i < TST_TOTAL; i++)
- (*testfunc[i])();
- }
-
- cleanup();
- tst_exit();
-}
+#include "tst_test.h"

static void setpgid_test1(void)
{
pid_t pgid, pid;

- pgid = getpgrp();
- pid = getpid();
+ pgid = TST_EXP_PID(getpgrp());
+ pid = TST_EXP_PID(getpid());

- TEST(setpgid(pid, pgid));
- if (TEST_RETURN == -1 || getpgrp() != pgid) {
- tst_resm(TFAIL | TTERRNO, "test setpgid(%d, %d) fail",
- pid, pgid);
- } else {
- tst_resm(TPASS, "test setpgid(%d, %d) success", pid, pgid);
- }
-}
-
-static int wait4child(pid_t child)
-{
- int status;
-
- if (waitpid(child, &status, 0) == -1)
- tst_resm(TBROK|TERRNO, "waitpid");
- if (WIFEXITED(status))
- return WEXITSTATUS(status);
- else
- return status;
+ TST_EXP_PASS(setpgid(pid, pgid));
+ TST_EXP_EQ_LI(pgid, getpgrp());
}

static void setpgid_test2(void)
{
- int ret;
- pid_t pgid, pid;
+ pid_t pgid;

- pid = tst_fork();
- if (pid == -1)
- tst_brkm(TBROK | TERRNO, cleanup, "fork()");
-
- if (pid != 0) {
- ret = wait4child(pid);
- } else {
- pid = getpid();
- TEST(setpgid(0, 0));
- pgid = getpgrp();
- if (TEST_RETURN == -1) {
- fprintf(stderr, "setpgid(0, 0) fails in "
- "child process: %s\n", strerror(TEST_ERRNO));
- exit(1);
- } else if (pgid != pid) {
- fprintf(stderr, "setpgid(0, 0) fails to make PGID"
- "equal to PID\n");
- exit(1);
- } else {
- exit(0);
- }
+ if (!SAFE_FORK()) {
+ pgid = TST_EXP_PID(getpid());
+ TST_EXP_PASS(setpgid(0, 0));
+ TST_EXP_EQ_LI(pgid, getpgrp());
}
-
- if (ret == 0)
- tst_resm(TPASS, "test setpgid(0, 0) success");
- else
- tst_resm(TFAIL, "test setpgid(0, 0) fail");
}

-
-static void setup(void)
+static void run(void)
{
- tst_sig(FORK, DEF_HANDLER, cleanup);
-
- TEST_PAUSE;
+ setpgid_test1();
+ setpgid_test2();
}

-static void cleanup(void)
-{
-}
+static struct tst_test test = {
+ .test_all = run,
+ .forks_child = 1,