Re: [LTP] [PATCH 2/2] testcases/lib: tst_net.sh: Do not use stderr in tst_rhost_run()

Cyril Hrubis
2025-01-17T13:45:35Z

Hi!
> I'm not sure about this. Maybe it's safe, because stderr gets to the output.
> But in case some network test need to verify something which is defined on
> stderr it will fails (when tst_rhost_run is run with -s).

That's why I send the first patch that I know is 100% safe.

> FYI *without* this patch:
>
> # route-redirect.sh
> ...
> route-redirect 1 TINFO: timeout per run is 0h 5m 0s
> route-redirect 1 TBROK: 'ns-icmp_redirector -I ltp_ns_veth1 -b' failed on '': 'sh: 1: ns-icmp_redirector: not found'
> route-redirect 1 TWARN: 'killall -SIGHUP ns-icmp_redirector' failed on '': 'ns-icmp_redirector: no process found'
> ns-icmp_redirector: no process found
>
> and *with* this patch:
>
> # route-redirect.sh
> ...
> route-redirect 1 TINFO: timeout per run is 0h 5m 0s
> sh: 1: ns-icmp_redirector: not found
> route-redirect 1 TBROK: 'ns-icmp_redirector -I ltp_ns_veth1 -b' failed on '': ''
> ns-icmp_redirector: no process found
> route-redirect 1 TWARN: 'killall -SIGHUP ns-icmp_redirector' failed on '': ''
>
> Info is there, but not on the same line (second '').
>
> Also with the change below it would be more meaningful (fixing first empty ''):
>
> route-redirect 1 TBROK: 'ns-icmp_redirector -I ltp_ns_veth1 -b' failed on NETNS: 'sh: 1: ns-icmp_redirector: not found'
> route-redirect 1 TWARN: 'killall -SIGHUP ns-icmp_redirector' failed on NETNS: 'ns-icmp_redirector: no process found'
> ns-icmp_redirector: no process found
>
> I also wrote conditional quiet on stderr (not sent to ML), but actually if we
> merge this and need sometimes to parse stderr, the opposite would be needed.

I supose that we would need to explicitly tell the tst_rhost_run() if we
want stderr included or not. That's probably something to be done after
the release.

--
Cyril Hrubis
chrubis@suse.cz