From: Cyril Hrubis <chrubis@suse.cz>
To: Petr Vorel <pvorel@suse.cz>
Cc: Sven Schnelle <svens@linux.ibm.com>, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] mmap01: initialize buffer in check_file()
Date: Wed, 22 Jan 2025 12:01:42 +0100 [thread overview]
Message-ID: <Z5DQFuQiIAGAqtK4@yuki.lan> (raw)
In-Reply-To: <20250122102648.GA29598@pevik>
Hi!
> > mmap01 reported random test failures. Turns out the
> > the temporary buffer in check_file() isn't initialized.
> > The SAFE_READ reads less then sizeof(buf) bytes so the
> > rest stays initialized and might contain bytes check_file()
> > is looking for.
>
> Looks reasonable to me.
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
>
> @Cyril a candidate for merge before the release.
Alternatively we could use the return value from the SAFE_READ() instead
of the buf_len. Also I suppose that we could check that we read at least
something.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2025-01-22 11:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-22 10:09 [LTP] [PATCH] mmap01: initialize buffer in check_file() Sven Schnelle
2025-01-22 10:26 ` Petr Vorel
2025-01-22 11:01 ` Cyril Hrubis [this message]
2025-01-22 12:13 ` Sven Schnelle
2025-01-22 12:28 ` Cyril Hrubis
2025-01-22 12:33 ` Sven Schnelle
2025-01-22 10:43 ` Ricardo B. Marliere via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z5DQFuQiIAGAqtK4@yuki.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
--cc=svens@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox