From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8F654C0218B for ; Fri, 24 Jan 2025 11:20:23 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 085303C5582 for ; Fri, 24 Jan 2025 12:20:22 +0100 (CET) Received: from in-4.smtp.seeweb.it (in-4.smtp.seeweb.it [IPv6:2001:4b78:1:20::4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 871093C527D for ; Fri, 24 Jan 2025 12:20:04 +0100 (CET) Authentication-Results: in-4.smtp.seeweb.it; spf=pass (sender SPF authorized) smtp.mailfrom=suse.cz (client-ip=2a07:de40:b251:101:10:150:64:2; helo=smtp-out2.suse.de; envelope-from=chrubis@suse.cz; receiver=lists.linux.it) Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-4.smtp.seeweb.it (Postfix) with ESMTPS id 5A82A102E422 for ; Fri, 24 Jan 2025 12:20:03 +0100 (CET) Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 86C461F393; Fri, 24 Jan 2025 11:20:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1737717602; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wTwV5nVlRrOEh1CwFMwJlE2LLweUHdq09LKeAz3ROL4=; b=ItPwFPPVuJi52ykDU48GynvVMiTETrChbxdNStXxvK656n5PmukPqQW2Z7WNIg4eKfu3Po vMBX2a7Q1yCEP94nW6pAWT7qUShoUT0bSyWJuPsGDVYqIoo7EhqWd14g+rB0bU/W2Pb3NG /9LRSy4H9ztdApa4iA0sQXuSNNQDZZE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1737717602; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wTwV5nVlRrOEh1CwFMwJlE2LLweUHdq09LKeAz3ROL4=; b=VXeB84GsdwTLrIAy3N2NWt3hL1rp8gEeNVRxGyqqHLMpSZGt6zaFhffl2TACafLSZcWK+P sRAOeUkZXv5wXRCA== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ItPwFPPV; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=VXeB84Gs DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1737717602; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wTwV5nVlRrOEh1CwFMwJlE2LLweUHdq09LKeAz3ROL4=; b=ItPwFPPVuJi52ykDU48GynvVMiTETrChbxdNStXxvK656n5PmukPqQW2Z7WNIg4eKfu3Po vMBX2a7Q1yCEP94nW6pAWT7qUShoUT0bSyWJuPsGDVYqIoo7EhqWd14g+rB0bU/W2Pb3NG /9LRSy4H9ztdApa4iA0sQXuSNNQDZZE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1737717602; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wTwV5nVlRrOEh1CwFMwJlE2LLweUHdq09LKeAz3ROL4=; b=VXeB84GsdwTLrIAy3N2NWt3hL1rp8gEeNVRxGyqqHLMpSZGt6zaFhffl2TACafLSZcWK+P sRAOeUkZXv5wXRCA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 739C313999; Fri, 24 Jan 2025 11:20:02 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id rvi6G2J3k2fIcgAAD6G6ig (envelope-from ); Fri, 24 Jan 2025 11:20:02 +0000 Date: Fri, 24 Jan 2025 12:19:57 +0100 From: Cyril Hrubis To: Li Wang Message-ID: References: <20250118102615.127485-1-liwang@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250118102615.127485-1-liwang@redhat.com> X-Rspamd-Queue-Id: 86C461F393 X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; MISSING_XM_UA(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; TO_DN_SOME(0.00)[]; FROM_HAS_DN(0.00)[]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DKIM_TRACE(0.00)[suse.cz:+] X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Action: no action X-Virus-Scanned: clamav-milter 1.0.3 at in-4.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH] lib: switch cgroup bit-fields from signed to unsigned int X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! > There is a problem in cgroup lib that the declearation int > can lead to -1 during the | operation. > > Becasue if the field contains uninitialized garbage data, > a bit-field declared as int could interpret 0b1 as -1 due > to signed arithmetic. Uff, so we have a number that can be either -1 or 0. Where did it break? I suppose that things are okay as long as we do if (s->bar | s->bar). Anyways: Reviewed-by: Cyril Hrubis -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp