From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CFFAFC0218D for ; Fri, 31 Jan 2025 11:33:07 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 3689E3C6609 for ; Fri, 31 Jan 2025 12:33:06 +0100 (CET) Received: from in-7.smtp.seeweb.it (in-7.smtp.seeweb.it [IPv6:2001:4b78:1:20::7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id C58FB3C6609 for ; Fri, 31 Jan 2025 12:32:49 +0100 (CET) Authentication-Results: in-7.smtp.seeweb.it; spf=pass (sender SPF authorized) smtp.mailfrom=suse.cz (client-ip=2a07:de40:b251:101:10:150:64:2; helo=smtp-out2.suse.de; envelope-from=chrubis@suse.cz; receiver=lists.linux.it) Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-7.smtp.seeweb.it (Postfix) with ESMTPS id AF69221DCA5 for ; Fri, 31 Jan 2025 12:32:48 +0100 (CET) Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 0F4591F38E; Fri, 31 Jan 2025 11:32:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1738323167; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OHq/ZyMGK+svVBeXnI80c+iY0ZNY3sObvPlgsc57SFU=; b=qMqhWuvF2RiordjgnJ4XIXhMP2k1J5U5FBosUYEQuwQd9I7KQjnfHWLhl45xCpjaYMmDAe ac95Njynrwogvb3MqV14EhGc+G7u+7N1F/tvNQlMAXdBXZmnrrUE0UPrNPMyiVYuTCecgX F/3xbBpZOqXd3MHabk1xuocxCCw+zhc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1738323167; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OHq/ZyMGK+svVBeXnI80c+iY0ZNY3sObvPlgsc57SFU=; b=8D5exhR3T3YWoKR+1MZeGw39enoXwUwVa4boZWYYGmOP1w4obslEtu9q09nuwVjOcdDrjc zKPTbqsDRHHUO1Cw== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1738323167; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OHq/ZyMGK+svVBeXnI80c+iY0ZNY3sObvPlgsc57SFU=; b=qMqhWuvF2RiordjgnJ4XIXhMP2k1J5U5FBosUYEQuwQd9I7KQjnfHWLhl45xCpjaYMmDAe ac95Njynrwogvb3MqV14EhGc+G7u+7N1F/tvNQlMAXdBXZmnrrUE0UPrNPMyiVYuTCecgX F/3xbBpZOqXd3MHabk1xuocxCCw+zhc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1738323167; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OHq/ZyMGK+svVBeXnI80c+iY0ZNY3sObvPlgsc57SFU=; b=8D5exhR3T3YWoKR+1MZeGw39enoXwUwVa4boZWYYGmOP1w4obslEtu9q09nuwVjOcdDrjc zKPTbqsDRHHUO1Cw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id F08FD1364B; Fri, 31 Jan 2025 11:32:46 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id vsWuOd60nGdjQgAAD6G6ig (envelope-from ); Fri, 31 Jan 2025 11:32:46 +0000 Date: Fri, 31 Jan 2025 12:32:45 +0100 From: Cyril Hrubis To: Petr Vorel Message-ID: References: <20250131091535.GB1090737@pevik> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250131091535.GB1090737@pevik> X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MISSING_XM_UA(0.00)[]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.cz:email] X-Virus-Scanned: clamav-milter 1.0.3 at in-7.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [RFC] Remove [Description] subtitle from docparse X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! > Can we remove [Description] part from docparse documentation in tests? > This is transformed into "Description" subtitle in resulted html/pdf. > > 1) It's not really needed (it's obvious that it's a description of the test) > 2) Sometimes it's missing (inconsistency). That part can be fixed with something as: diff --git a/metadata/metaparse.c b/metadata/metaparse.c index 2b96149dc..422604a2c 100644 --- a/metadata/metaparse.c +++ b/metadata/metaparse.c @@ -852,6 +852,14 @@ static struct data_node *parse_file(const char *fname) if (data_node_array_len(doc)) { data_node_hash_add(res, "doc", doc); + + char *str = doc->array.array[0]->string.val; + + if (!strstr("[Description]", str)) { + fprintf(stderr, "%s: Missing [Description] in doc comment!\n", fname); + exit(1); + } + found = 1; } else { data_node_free(doc); > I would keep other subtitles (e.g. [Algorithm]), just remove the first one. I find it a bit inconsistent if we do it this way, but I guess either way is fine. -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp