Linux Test Project
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: "Ricardo B. Marlière" <rbm@suse.com>
Cc: Linux Test Project <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH v3 4/5] syscalls/pause03: Refactor into new API
Date: Wed, 26 Feb 2025 17:00:48 +0100	[thread overview]
Message-ID: <Z786sJf4MyshC-my@yuki.lan> (raw)
In-Reply-To: <20250224-conversions-pause-v3-4-5e3989d37f1d@suse.com>

Hi!
Applied with minor change, thanks:

diff --git a/testcases/kernel/syscalls/pause/pause03.c b/testcases/kernel/syscalls/pause/pause03.c
index 9d7fee1e8..612209935 100644
--- a/testcases/kernel/syscalls/pause/pause03.c
+++ b/testcases/kernel/syscalls/pause/pause03.c
@@ -14,7 +14,8 @@
 void do_child(void)
 {
        TST_CHECKPOINT_WAKE(0);
-       TST_EXP_PASS(pause());
+       pause();
+       tst_res(TFAIL, "pause() returned after SIGKILL");
 }

 void run(void)
@@ -34,7 +35,7 @@ void run(void)
        SAFE_WAITPID(pid, &status, 0);

        if (WIFSIGNALED(status) && WTERMSIG(status) == SIGKILL)
-               tst_res(TPASS, "pause() did not return after SIGKILL");
+               tst_res(TPASS, "pause() killed by SIGKILL");
        else
                tst_res(TFAIL, "Child %s", tst_strstatus(status));
 }

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2025-02-26 16:00 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-24 18:53 [LTP] [PATCH v3 0/5] syscalls/pause: Refactor tests Ricardo B. Marlière via ltp
2025-02-24 18:53 ` [LTP] [PATCH v3 1/5] syscalls/pause01: Clean up Ricardo B. Marlière via ltp
2025-02-24 18:53 ` [LTP] [PATCH v3 2/5] syscalls/pause01: Extend test to other signals Ricardo B. Marlière via ltp
2025-02-24 18:53 ` [LTP] [PATCH v3 3/5] syscalls/pause02: Delete duplicated test Ricardo B. Marlière via ltp
2025-02-24 19:24   ` Ricardo B. Marlière via ltp
2025-02-26 16:07     ` Cyril Hrubis
2025-02-26 16:27       ` Ricardo B. Marlière via ltp
2025-02-26 16:35         ` Cyril Hrubis
2025-02-26 16:40           ` Ricardo B. Marlière
2025-02-27  9:28             ` Cyril Hrubis
2025-02-24 18:53 ` [LTP] [PATCH v3 4/5] syscalls/pause03: Refactor into new API Ricardo B. Marlière via ltp
2025-02-26 16:00   ` Cyril Hrubis [this message]
2025-02-24 18:53 ` [LTP] [PATCH v3 5/5] syscalls/pause03: Rename to pause02 Ricardo B. Marlière via ltp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z786sJf4MyshC-my@yuki.lan \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    --cc=rbm@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox