From: Cyril Hrubis <chrubis@suse.cz>
To: Jan Stancek <jstancek@redhat.com>
Cc: liwan@redhat.com, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] syscalls/utime03: relax the check for 1 second difference
Date: Thu, 20 Feb 2025 12:17:36 +0100 [thread overview]
Message-ID: <Z7cPUCOZeJZipmo0@yuki.lan> (raw)
In-Reply-To: <b379b9603036d9d4877f562f750e2d1515dfd962.1740042744.git.jstancek@redhat.com>
Hi!
> The test is using tst_get_fs_timestamp() which is using REALTIME_COARSE
> clock, which is slightly less accurate. Back in 2022 we added extra log
> message to print also min and max time. In those rare instances where
> it fails this extra log shows it failed by one second difference.
>
> Relax the check a little. Tested on aarch64 VMs, where it's usually
> reproducible after couple hundred iterations.
Aren't we just masking a kernel bug here? Back then we discussed this
with kernel devs and they told us that filesystems use REALTIME_COARSE
internally, so this shouldn't really fail.
What filesystem is this? Does it, by chance, use more granual
timestamps?
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2025-02-20 11:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-20 9:28 [LTP] [PATCH] syscalls/utime03: relax the check for 1 second difference Jan Stancek
2025-02-20 10:51 ` Petr Vorel
2025-02-20 11:17 ` Cyril Hrubis [this message]
2025-02-20 13:44 ` Jan Stancek
2025-02-21 8:24 ` Jan Stancek
2025-02-24 11:24 ` [LTP] [PATCH v2] syscalls/utime03: use realtime clock for upper bound check Jan Stancek
2025-02-24 15:41 ` Cyril Hrubis
2025-02-24 16:06 ` Jan Stancek
2025-02-25 11:39 ` [LTP] [PATCH v3] provide separate functions for getting start and end fs timestamps Jan Stancek
2025-02-25 13:18 ` Cyril Hrubis
2025-02-28 12:22 ` Jan Stancek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z7cPUCOZeJZipmo0@yuki.lan \
--to=chrubis@suse.cz \
--cc=jstancek@redhat.com \
--cc=liwan@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox