From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E6F26C19776 for ; Fri, 28 Feb 2025 11:05:26 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 465283C9E45 for ; Fri, 28 Feb 2025 12:05:25 +0100 (CET) Received: from in-3.smtp.seeweb.it (in-3.smtp.seeweb.it [IPv6:2001:4b78:1:20::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 3CDDA3C2CCC for ; Fri, 28 Feb 2025 12:05:08 +0100 (CET) Authentication-Results: in-3.smtp.seeweb.it; spf=pass (sender SPF authorized) smtp.mailfrom=suse.cz (client-ip=195.135.223.130; helo=smtp-out1.suse.de; envelope-from=chrubis@suse.cz; receiver=lists.linux.it) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-3.smtp.seeweb.it (Postfix) with ESMTPS id 6B54F1A0CE56 for ; Fri, 28 Feb 2025 12:05:06 +0100 (CET) Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7DEB021165; Fri, 28 Feb 2025 11:05:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1740740705; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=T47/5U3XBnVFDfs9vVXAKE9Q77J6NNCR5+j+UiC+rSI=; b=byyGbyWUf2eucD0MesqKscZO4+08/T9wph1OrRa29lnukVgMa1FtD47HusxoVp6pCsLvj4 NX7PgAnT8ejFrsChFNc/K66LgwgWuETKcXLlP7fma7mNz9WAB2HLrx5esyR0O8Sz5uLZcq NPpW+BkYx1C9d2g6yLgrbhNFXUbhNXo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1740740705; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=T47/5U3XBnVFDfs9vVXAKE9Q77J6NNCR5+j+UiC+rSI=; b=odrMsh7Ic5odek1UuwpovJNFyeVF+DOBj0AWQnJ1pQBqBXh3dvpdJ1Ik+uP1qB23BV4naU su5ACPTm4vj2ZYBA== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1740740705; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=T47/5U3XBnVFDfs9vVXAKE9Q77J6NNCR5+j+UiC+rSI=; b=byyGbyWUf2eucD0MesqKscZO4+08/T9wph1OrRa29lnukVgMa1FtD47HusxoVp6pCsLvj4 NX7PgAnT8ejFrsChFNc/K66LgwgWuETKcXLlP7fma7mNz9WAB2HLrx5esyR0O8Sz5uLZcq NPpW+BkYx1C9d2g6yLgrbhNFXUbhNXo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1740740705; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=T47/5U3XBnVFDfs9vVXAKE9Q77J6NNCR5+j+UiC+rSI=; b=odrMsh7Ic5odek1UuwpovJNFyeVF+DOBj0AWQnJ1pQBqBXh3dvpdJ1Ik+uP1qB23BV4naU su5ACPTm4vj2ZYBA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 6B7861344A; Fri, 28 Feb 2025 11:05:05 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id PwBtGWGYwWf2bgAAD6G6ig (envelope-from ); Fri, 28 Feb 2025 11:05:05 +0000 Date: Fri, 28 Feb 2025 12:05:10 +0100 From: Cyril Hrubis To: Edward Liaw Message-ID: References: <20250227180512.355110-1-edliaw@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250227180512.355110-1-edliaw@google.com> X-Spamd-Result: default: False [-8.30 / 50.00]; REPLY(-4.00)[]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.999]; MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[]; URIBL_BLOCKED(0.00)[yuki.lan:mid,suse.cz:email,imap1.dmz-prg2.suse.org:helo]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; ARC_NA(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; MIME_TRACE(0.00)[0:+]; FROM_HAS_DN(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; FROM_EQ_ENVFROM(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; MISSING_XM_UA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.cz:email] X-Virus-Scanned: clamav-milter 1.0.3 at in-3.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH] input_common.h: Add retry loop for event device X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-team@android.com, ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! > + for (int i = 100 ; i > 0 ; i--) { > + if (!access(path, F_OK)) { > + tst_res(TINFO, "Found event device: %s", path); > + break; > + } > + usleep(10000); We do have a TST_RETRY_FUNC() in include/tst_common.h that is slightly smarter than this loop and also properly scales the timeout on slow devices automaticaly. So this should be: if (!TST_RETRY_FUNC(access(path, F_OK), TST_RETVAL_NULL)) { tst_res(TINFO, "Found event device: %s", path); break; } -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp