From: Cyril Hrubis <chrubis@suse.cz>
To: Edward Liaw <edliaw@google.com>
Cc: "kuan-ying.zhu" <kuan-ying.zhu@mediatek.com>,
kernel-team@android.com, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] perf_event_open02: set process as RT during Setup stage
Date: Tue, 18 Mar 2025 12:19:22 +0100 [thread overview]
Message-ID: <Z9lWurYY7h33xtBV@yuki.lan> (raw)
In-Reply-To: <20250227184907.392133-1-edliaw@google.com>
Hi!
> Move the action of set the task RT from the Verify stage to the Setup
> stage. Avoid potential risks of task migration due to scheduler policy.
What exactly goes wrong if we switch to the realtime policy later? I
see that we do bench_work(500) at the start of the setup. That may mean
that we may get different estimate on how many loops we do per second,
but that would only mean that the test would run for shorter time.
We also do bind_to_current_cpu() just after that, the task shouldn't be
migrated after that.
The actual change looks reasonable, however the patch description should
tell why we need to do this change.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2025-03-18 11:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-27 18:49 [LTP] [PATCH] perf_event_open02: set process as RT during Setup stage Edward Liaw via ltp
2025-03-18 11:19 ` Cyril Hrubis [this message]
2025-05-05 7:09 ` [LTP] 回覆: " Kuan-ying Zhu (朱冠穎) via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9lWurYY7h33xtBV@yuki.lan \
--to=chrubis@suse.cz \
--cc=edliaw@google.com \
--cc=kernel-team@android.com \
--cc=kuan-ying.zhu@mediatek.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox