Re: [LTP] [PATCH v1] Rewrite ns_exec tool using new LTP API

[Petr Vorel <pvorel@suse.cz>]

> Hi Petr,

> On 3/3/23 15:29, Petr Vorel wrote:
> > Hi Andrea,

> > Reviewed-by: Petr Vorel <pvorel@suse.cz>

> > I'm going to merge without struct tst_test workarounds.
> > IMHO it works without it. Or am I missing something?
> Unfortunately it's needed because of SAFE_CLONE. We can't use it without
> forcing "forks_child = 1".
Yes, I read that in the comment. But the problem was somehow hidden.
It looks like Segmentation fault appear only if run on fresh reboot, that's why
I got confused it's not needed. Sorry for asking without looking into
safe_clone() before.

Also we had some discussion in the past whether tools should use the test
library at all (see below), but in this case I'd be for keeping it
(we don't want to reimplement tst_clone() and TST_RETRY_FUNC()).

> > Kind regards,
> > Petr

> Beware that this patch will touch the whole network testing suites since
> it's used in "tst_net.sh".
Yes, I know :). That was the reason why I also started to rewrite these tests,
with intention to move them to testcases/lib/ (although these files are both
tests and tools, we agreed with Cyril it's better to move them).

> Regards,
> Andrea


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp