From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2A0D3C6FD1F for ; Tue, 14 Mar 2023 09:14:06 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 174C03CAEB1 for ; Tue, 14 Mar 2023 10:14:04 +0100 (CET) Received: from in-6.smtp.seeweb.it (in-6.smtp.seeweb.it [IPv6:2001:4b78:1:20::6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 118173CACF9 for ; Tue, 14 Mar 2023 10:13:53 +0100 (CET) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-6.smtp.seeweb.it (Postfix) with ESMTPS id 69AF41400B8F for ; Tue, 14 Mar 2023 10:13:52 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 79B5D21A1B; Tue, 14 Mar 2023 09:13:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1678785232; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=F3HToc028lhUjdMXj7ThYkPzQjy1z7TENByZOBzWyZ4=; b=jfqhoWSx9p0O8M2XmTo9wpmNhB93IxtSGCUTWcRZM/ufCp7fwYauGhqxqBDKKN67U3efPo +xFI5S0XhlDQf5wDCPblEBUi9QVZ5piI0nglGiuqV4WaryPWO28qKp206YB73K5j7Iey36 imeyjRyfE1Usvqr9PA7M/HgrhpEjbV8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1678785232; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=F3HToc028lhUjdMXj7ThYkPzQjy1z7TENByZOBzWyZ4=; b=xvpSRTmF+g/+qEfB+HmQJnsT2fxw8nLkcNVPDLMj4Df7YcblOE/OCM+e+YkkbN/CJYwwLO jC7LEF+iYxqXToBA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 640C913A1B; Tue, 14 Mar 2023 09:13:52 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 29pZF9A6EGSGXwAAMHmgww (envelope-from ); Tue, 14 Mar 2023 09:13:52 +0000 Date: Tue, 14 Mar 2023 10:15:11 +0100 From: Cyril Hrubis To: Richard Palethorpe Message-ID: References: <20230311023343.25177-1-wegao@suse.com> <20230312004420.16457-1-wegao@suse.com> <20230313122100.GA12608@localhost> <20230313134624.GA9783@localhost> <20230314053151.GA22202@localhost> <87pm9b67gc.fsf@suse.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87pm9b67gc.fsf@suse.de> X-Virus-Scanned: clamav-milter 0.102.4 at in-6.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v3] madvise11.c:Check loadable module before rmmod X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! > > Sounds like a bug that shoudl be fixed, we probably need to create two > > search strings, one with dashes and one with underscores and try to > > strstr() both. > > Could we not check kconfig for builtin modules? Are we 100% sure that the module-name always translates to CONFIG_MODULE_NAME? I would say that we are a bit safer if we use the same files the rest of the tooling uses e.g. depmod, dracut etc. -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp