From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A4238C6FD1C for ; Wed, 22 Mar 2023 16:42:43 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id CB8F63CD2A7 for ; Wed, 22 Mar 2023 17:42:41 +0100 (CET) Received: from in-6.smtp.seeweb.it (in-6.smtp.seeweb.it [217.194.8.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 27AB03C5624 for ; Wed, 22 Mar 2023 17:42:30 +0100 (CET) Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-6.smtp.seeweb.it (Postfix) with ESMTPS id 725B71400982 for ; Wed, 22 Mar 2023 17:42:29 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 2FC6021003; Wed, 22 Mar 2023 16:42:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1679503348; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vnHmGltMrD8UJPdqBJ2w69/tvxqIcz7OH/u/DGlsQns=; b=YikZZAZQnZzFMe6GWiKEOi6LfLRt7c+Lvd51QTfe0kQBeqc0aDrFxJP/IGP/9FWarfCrfj TG1HV4EWJ//DFqa1PGMa4VQZgzayTN54fVONPLWAZqxIyTjssYEpRqZemdJ53Bf1h3WaQY 8VSGUurQ36On8yn/V+wlAB88ZtNw4Jw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1679503348; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vnHmGltMrD8UJPdqBJ2w69/tvxqIcz7OH/u/DGlsQns=; b=ZUK2l9l23jbtYD8+rrRhFlRzCdZxOeA+Uz3f1Y9+asylfcOHIpwNT3dHO+ied9vTnbphy8 Rq6PY/1kcUC82DCg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1210313416; Wed, 22 Mar 2023 16:42:28 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id lPUXBPQvG2TQdwAAMHmgww (envelope-from ); Wed, 22 Mar 2023 16:42:28 +0000 Date: Wed, 22 Mar 2023 17:43:39 +0100 From: Cyril Hrubis To: Petr Vorel Message-ID: References: <20230314114037.25581-1-rpalethorpe@suse.com> <20230314175438.GB79562@pevik> <20230320080415.GA179863@pevik> <20230320082336.GA182681@pevik> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230320082336.GA182681@pevik> X-Virus-Scanned: clamav-milter 0.102.4 at in-6.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH] Add goals of patch review and tips X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Palethorpe , ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! > > + also add Tested: link-to-github-actions-run below --- in patch would help > > (it's than obvious that maintainer does not have to bother with doing it or > > not hope that it fails on CentOS 7 old compiler or very new Fedora compiler). > > > Maybe also encourage people to create account in the patchwork and maintain > > status their patches would help (set "Superseded" if they sent new patch version, > > other statuses like "Accepted" or "Changes requested" are also sometimes > > forgotten by the maintainer who post comments or merge the patch). > Example why helping to maintain the patches by submitter would help: > mknod01: Rewrite the test using new LTP API [1] followed by [v2,1/1] mknod01: > Rewrite the test using new LTP API [2]. > > Li reviewed v2, but later Cyril pushed v1 (manually updating patch) without > update patchwork. (Li review was ignored, I tried to apply v2 to merge it > because status was not updated.) Sorry for that, that happened because v2 was marked as changes requsted but v1 kept hanging in patchwork and I only realized that later... -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp