ltp.lists.linux.it archive mirror
 help / color / mirror / Atom feed
* Re: [LTP] [PATCH 5.4 00/92] 5.4.241-rc1 review
       [not found] <20230418120304.658273364@linuxfoundation.org>
@ 2023-04-19  7:41 ` Naresh Kamboju
  2023-04-19  7:58   ` Cyril Hrubis
  0 siblings, 1 reply; 4+ messages in thread
From: Naresh Kamboju @ 2023-04-19  7:41 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: f.fainelli, rwarsow, pavel, shuah, LTP List, patches, stable,
	linux-kernel, Arnd Bergmann, lkft-triage, srw, patches, akpm,
	jonathanh, torvalds, sudipm.mukherjee, linux

On Tue, 18 Apr 2023 at 17:59, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> This is the start of the stable review cycle for the 5.4.241 release.
> There are 92 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Thu, 20 Apr 2023 12:02:44 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
>         https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.241-rc1.gz
> or in the git tree and branch at:
>         git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h


Recently we have upgraded the LTP test suite version and started noticing
these test failures on 5.4.
Test getting skipped on 4.19 and 4.14 as not supported features.

Need to investigate test case issues or kernel issues.

Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>

NOTE:

---
creat09.c:73: TINFO: User nobody: uid = 65534, gid = 65534
creat09.c:75: TINFO: Found unused GID 11: SUCCESS (0)
creat09.c:120: TINFO: File created with umask(0)
creat09.c:106: TPASS: mntpoint/testdir/creat.tmp: Owned by correct group
creat09.c:112: TPASS: mntpoint/testdir/creat.tmp: Setgid bit not set
creat09.c:106: TPASS: mntpoint/testdir/open.tmp: Owned by correct group
creat09.c:112: TPASS: mntpoint/testdir/open.tmp: Setgid bit not set
creat09.c:120: TINFO: File created with umask(S_IXGRP)
creat09.c:106: TPASS: mntpoint/testdir/creat.tmp: Owned by correct group
creat09.c:110: TFAIL: mntpoint/testdir/creat.tmp: Setgid bit is set
creat09.c:106: TPASS: mntpoint/testdir/open.tmp: Owned by correct group
creat09.c:110: TFAIL: mntpoint/testdir/open.tmp: Setgid bit is set

Test history links,
 - https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-5.4.y/build/v5.4.238-199-g230f1bde44b6/testrun/16338751/suite/ltp-syscalls/test/creat09/history/
 - https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-5.4.y/build/v5.4.238-199-g230f1bde44b6/testrun/16337895/suite/ltp-cve/test/cve-2018-13405/history/
 - https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-5.4.y/build/v5.4.238-199-g230f1bde44b6/testrun/16338751/suite/ltp-syscalls/test/creat09/log

---

fanotify14.c:161: TCONF: FAN_REPORT_TARGET_FID not supported in kernel?
fanotify14.c:157: TINFO: Test case 7: fanotify_init(FAN_CLASS_NOTIF |
FAN_REPORT_TARGET_FID | FAN_REPORT_DFID_FID, O_RDONLY)
fanotify14.c:161: TCONF: FAN_REPORT_TARGET_FID not supported in kernel?
[  377.081993] EXT4-fs (loop0): mounting ext3 file system using the
ext4 subsystem
fanotify14.c:157: TINFO: Test case 8: fanotify_init(FAN_CLASS_NOTIF |
FAN_REPORT_DFID_FID, O_RDONLY)
[  377.099137] EXT4-fs (loop0): mounted filesystem with ordered data
mode. Opts: (null)
fanotify14.c:175: TFAIL: fanotify_init(tc->init.flags, O_RDONLY)
failed: EINVAL (22)

Test results compare:
 - https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-5.4.y/build/v5.4.238-199-g230f1bde44b6/testrun/16339099/suite/ltp-syscalls/test/fanotify14/history/
 - https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-5.4.y/build/v5.4.238-199-g230f1bde44b6/testrun/16326877/suite/ltp-syscalls/test/fanotify14/log



## Build
* kernel: 5.4.241-rc1
* git: https://gitlab.com/Linaro/lkft/mirrors/stable/linux-stable-rc
* git branch: linux-5.4.y
* git commit: 230f1bde44b6ca667cdddf6634ea4adc0bbcd0ef
* git describe: v5.4.238-199-g230f1bde44b6
* test details:
https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-5.4.y/build/v5.4.238-199-g230f1bde44b6

## Test Regressions (compared to v5.4.238-107-g73330daa3393)

* qemu-arm64, ltp-cve
  - cve-2018-13405 ( creat09 )

* qemu-arm64, ltp-cve
  - creat09

* qemu_arm64,  qemu-armv7, qemu-x86_64, qemu-i386, ltp-syscalls
  - fanotify14

## Metric Regressions (compared to v5.4.238-107-g73330daa3393)

## Test Fixes (compared to v5.4.238-107-g73330daa3393)

## Metric Fixes (compared to v5.4.238-107-g73330daa3393)

## Test result summary
total: 127111, pass: 101779, fail: 3337, skip: 21744, xfail: 251

## Build Summary
* arc: 5 total, 5 passed, 0 failed
* arm: 143 total, 142 passed, 1 failed
* arm64: 43 total, 39 passed, 4 failed
* i386: 26 total, 20 passed, 6 failed
* mips: 27 total, 27 passed, 0 failed
* parisc: 6 total, 6 passed, 0 failed
* powerpc: 30 total, 30 passed, 0 failed
* riscv: 12 total, 10 passed, 2 failed
* s390: 6 total, 6 passed, 0 failed
* sh: 12 total, 12 passed, 0 failed
* sparc: 6 total, 6 passed, 0 failed
* x86_64: 36 total, 34 passed, 2 failed

## Test suites summary
* boot
* igt-gpu-tools
* kselftest-android
* kselftest-arm64
* kselftest-breakpoints
* kselftest-capabilities
* kselftest-cgroup
* kselftest-clone3
* kselftest-core
* kselftest-cpu-hotplug
* kselftest-cpufreq
* kselftest-drivers-dma-buf
* kselftest-efivarfs
* kselftest-filesystems
* kselftest-filesystems-binderfs
* kselftest-firmware
* kselftest-fpu
* kselftest-ftrace
* kselftest-futex
* kselftest-gpio
* kselftest-intel_pstate
* kselftest-ipc
* kselftest-ir
* kselftest-kcmp
* kselftest-kexec
* kselftest-kvm
* kselftest-lib
* kselftest-livepatch
* kselftest-membarrier
* kselftest-memfd
* kselftest-memory-hotplug
* kselftest-mincore
* kselftest-mount
* kselftest-mqueue
* kselftest-net
* kselftest-net-forwarding
* kselftest-netfilter
* kselftest-nsfs
* kselftest-openat2
* kselftest-pid_namespace
* kselftest-pidfd
* kselftest-proc
* kselftest-pstore
* kselftest-ptrace
* kselftest-rseq
* kselftest-rtc
* kselftest-tc-testing
* kselftest-timens
* kselftest-timers
* kselftest-tmpfs
* kselftest-tpm2
* kselftest-user
* kselftest-vm
* kselftest-x86
* kselftest-zram
* kunit
* kvm-unit-tests
* libhugetlbfs
* log-parser-boot
* log-parser-test
* ltp-cap_bounds
* ltp-commands
* ltp-containers
* ltp-controllers
* ltp-cpuhotplug
* ltp-crypto
* ltp-cve
* ltp-dio
* ltp-fcntl-locktests
* ltp-filecaps
* ltp-fs
* ltp-fs_bind
* ltp-fs_perms_simple
* ltp-fsx
* ltp-hugetlb
* ltp-io
* ltp-ipc
* ltp-math
* ltp-mm
* ltp-nptl
* ltp-pty
* ltp-sched
* ltp-securebits
* ltp-smoke
* ltp-syscalls
* ltp-tracing
* network-basic-tests
* perf
* rcutorture
* v4l2-compliance
* vdso

--
Linaro LKFT
https://lkft.linaro.org

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [LTP] [PATCH 5.4 00/92] 5.4.241-rc1 review
  2023-04-19  7:41 ` [LTP] [PATCH 5.4 00/92] 5.4.241-rc1 review Naresh Kamboju
@ 2023-04-19  7:58   ` Cyril Hrubis
  2023-04-21  8:04     ` Petr Vorel
  0 siblings, 1 reply; 4+ messages in thread
From: Cyril Hrubis @ 2023-04-19  7:58 UTC (permalink / raw)
  To: Naresh Kamboju
  Cc: shuah, f.fainelli, Arnd Bergmann, rwarsow, pavel,
	Greg Kroah-Hartman, LTP List, patches, stable, linux-kernel,
	lkft-triage, srw, patches, akpm, jonathanh, torvalds,
	sudipm.mukherjee, linux

Hi!
> > This is the start of the stable review cycle for the 5.4.241 release.
> > There are 92 patches in this series, all will be posted as a response
> > to this one.  If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Thu, 20 Apr 2023 12:02:44 +0000.
> > Anything received after that time might be too late.
> >
> > The whole patch series can be found in one patch at:
> >         https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.241-rc1.gz
> > or in the git tree and branch at:
> >         git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y
> > and the diffstat can be found below.
> >
> > thanks,
> >
> > greg k-h
> 
> 
> Recently we have upgraded the LTP test suite version and started noticing
> these test failures on 5.4.
> Test getting skipped on 4.19 and 4.14 as not supported features.
> 
> Need to investigate test case issues or kernel issues.
> 
> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> 
> NOTE:
> 
> ---
> creat09.c:73: TINFO: User nobody: uid = 65534, gid = 65534
> creat09.c:75: TINFO: Found unused GID 11: SUCCESS (0)
> creat09.c:120: TINFO: File created with umask(0)
> creat09.c:106: TPASS: mntpoint/testdir/creat.tmp: Owned by correct group
> creat09.c:112: TPASS: mntpoint/testdir/creat.tmp: Setgid bit not set
> creat09.c:106: TPASS: mntpoint/testdir/open.tmp: Owned by correct group
> creat09.c:112: TPASS: mntpoint/testdir/open.tmp: Setgid bit not set
> creat09.c:120: TINFO: File created with umask(S_IXGRP)
> creat09.c:106: TPASS: mntpoint/testdir/creat.tmp: Owned by correct group
> creat09.c:110: TFAIL: mntpoint/testdir/creat.tmp: Setgid bit is set
> creat09.c:106: TPASS: mntpoint/testdir/open.tmp: Owned by correct group
> creat09.c:110: TFAIL: mntpoint/testdir/open.tmp: Setgid bit is set
> 
> Test history links,
>  - https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-5.4.y/build/v5.4.238-199-g230f1bde44b6/testrun/16338751/suite/ltp-syscalls/test/creat09/history/
>  - https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-5.4.y/build/v5.4.238-199-g230f1bde44b6/testrun/16337895/suite/ltp-cve/test/cve-2018-13405/history/
>  - https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-5.4.y/build/v5.4.238-199-g230f1bde44b6/testrun/16338751/suite/ltp-syscalls/test/creat09/log

That's likely a missing kernel patch, as this is a regression test there
should have been links to the patches and CVE referencies in the test
output as the test is tagged with kernel commits and CVE numbers:

        .tags = (const struct tst_tag[]) {
                {"linux-git", "0fa3ecd87848"},
                {"CVE", "2018-13405"},
                {"CVE", "2021-4037"},
                {"linux-git", "01ea173e103e"},
                {"linux-git", "1639a49ccdce"},
                {"linux-git", "426b4ca2d6a5"},
                {}
        },

> ---
> 
> fanotify14.c:161: TCONF: FAN_REPORT_TARGET_FID not supported in kernel?
> fanotify14.c:157: TINFO: Test case 7: fanotify_init(FAN_CLASS_NOTIF |
> FAN_REPORT_TARGET_FID | FAN_REPORT_DFID_FID, O_RDONLY)
> fanotify14.c:161: TCONF: FAN_REPORT_TARGET_FID not supported in kernel?
> [  377.081993] EXT4-fs (loop0): mounting ext3 file system using the
> ext4 subsystem
> fanotify14.c:157: TINFO: Test case 8: fanotify_init(FAN_CLASS_NOTIF |
> FAN_REPORT_DFID_FID, O_RDONLY)
> [  377.099137] EXT4-fs (loop0): mounted filesystem with ordered data
> mode. Opts: (null)
> fanotify14.c:175: TFAIL: fanotify_init(tc->init.flags, O_RDONLY)
> failed: EINVAL (22)

Possibly like the test may be missing check for a FAN_REPORT_DFID_FID
support.

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [LTP] [PATCH 5.4 00/92] 5.4.241-rc1 review
  2023-04-19  7:58   ` Cyril Hrubis
@ 2023-04-21  8:04     ` Petr Vorel
  2023-04-24  6:36       ` Yang Xu (Fujitsu)
  0 siblings, 1 reply; 4+ messages in thread
From: Petr Vorel @ 2023-04-21  8:04 UTC (permalink / raw)
  To: Cyril Hrubis
  Cc: lkft-triage, linux-kernel, shuah, f.fainelli, jonathanh, patches,
	linux, Arnd Bergmann, srw, LTP List, rwarsow, pavel, patches,
	stable, Greg Kroah-Hartman, akpm, torvalds, sudipm.mukherjee

> Hi!
> > > This is the start of the stable review cycle for the 5.4.241 release.
> > > There are 92 patches in this series, all will be posted as a response
> > > to this one.  If anyone has any issues with these being applied, please
> > > let me know.

> > > Responses should be made by Thu, 20 Apr 2023 12:02:44 +0000.
> > > Anything received after that time might be too late.

> > > The whole patch series can be found in one patch at:
> > >         https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.241-rc1.gz
> > > or in the git tree and branch at:
> > >         git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y
> > > and the diffstat can be found below.

> > > thanks,

> > > greg k-h


> > Recently we have upgraded the LTP test suite version and started noticing
> > these test failures on 5.4.
> > Test getting skipped on 4.19 and 4.14 as not supported features.

> > Need to investigate test case issues or kernel issues.

> > Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>

> > NOTE:

> > ---
> > creat09.c:73: TINFO: User nobody: uid = 65534, gid = 65534
> > creat09.c:75: TINFO: Found unused GID 11: SUCCESS (0)
> > creat09.c:120: TINFO: File created with umask(0)
> > creat09.c:106: TPASS: mntpoint/testdir/creat.tmp: Owned by correct group
> > creat09.c:112: TPASS: mntpoint/testdir/creat.tmp: Setgid bit not set
> > creat09.c:106: TPASS: mntpoint/testdir/open.tmp: Owned by correct group
> > creat09.c:112: TPASS: mntpoint/testdir/open.tmp: Setgid bit not set
> > creat09.c:120: TINFO: File created with umask(S_IXGRP)
> > creat09.c:106: TPASS: mntpoint/testdir/creat.tmp: Owned by correct group
> > creat09.c:110: TFAIL: mntpoint/testdir/creat.tmp: Setgid bit is set
> > creat09.c:106: TPASS: mntpoint/testdir/open.tmp: Owned by correct group
> > creat09.c:110: TFAIL: mntpoint/testdir/open.tmp: Setgid bit is set

> > Test history links,
> >  - https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-5.4.y/build/v5.4.238-199-g230f1bde44b6/testrun/16338751/suite/ltp-syscalls/test/creat09/history/
> >  - https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-5.4.y/build/v5.4.238-199-g230f1bde44b6/testrun/16337895/suite/ltp-cve/test/cve-2018-13405/history/
> >  - https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-5.4.y/build/v5.4.238-199-g230f1bde44b6/testrun/16338751/suite/ltp-syscalls/test/creat09/log

> That's likely a missing kernel patch, as this is a regression test there
> should have been links to the patches and CVE referencies in the test
> output as the test is tagged with kernel commits and CVE numbers:

>         .tags = (const struct tst_tag[]) {
>                 {"linux-git", "0fa3ecd87848"},
>                 {"CVE", "2018-13405"},
>                 {"CVE", "2021-4037"},
>                 {"linux-git", "01ea173e103e"},
Only this one has been backported (as
e76bd6da51235ce86f5a8017dd6c056c76da64f9), the other two are missing.
>                 {"linux-git", "1639a49ccdce"},
>                 {"linux-git", "426b4ca2d6a5"},
The last one is merge tag, I wonder if it's correct:
426b4ca2d6a5 ("Merge tag 'fs.setgid.v6.0' of git://git.kernel.org/pub/scm/linux/kernel/git/brauner/linux")
Maybe just 1639a49ccdce would be ok.

@Yang Xu
1) why 1639a49ccdce has not been merged to stable tree? It does not apply now,
was that the only reason? Or is it not applicable?

@Yang Xu is really 426b4ca2d6a5 needed? Was it easier to list merge commit than
particular fixes? Merge commit contains:

5fadbd992996 ("ceph: rely on vfs for setgid stripping")
1639a49ccdce ("fs: move S_ISGID stripping into the vfs_*() helpers")
ac6800e279a2 ("fs: Add missing umask strip in vfs_tmpfile")
2b3416ceff5e ("fs: add mode_strip_sgid() helper")

They have not been backported to 5.4 stable, nor to the older releases.
Again, they don't apply.


>                 {}
>         },

> > ---

> > fanotify14.c:161: TCONF: FAN_REPORT_TARGET_FID not supported in kernel?
> > fanotify14.c:157: TINFO: Test case 7: fanotify_init(FAN_CLASS_NOTIF |
> > FAN_REPORT_TARGET_FID | FAN_REPORT_DFID_FID, O_RDONLY)
> > fanotify14.c:161: TCONF: FAN_REPORT_TARGET_FID not supported in kernel?
> > [  377.081993] EXT4-fs (loop0): mounting ext3 file system using the
> > ext4 subsystem
> > fanotify14.c:157: TINFO: Test case 8: fanotify_init(FAN_CLASS_NOTIF |
> > FAN_REPORT_DFID_FID, O_RDONLY)
> > [  377.099137] EXT4-fs (loop0): mounted filesystem with ordered data
> > mode. Opts: (null)
> > fanotify14.c:175: TFAIL: fanotify_init(tc->init.flags, O_RDONLY)
> > failed: EINVAL (22)

> Possibly like the test may be missing check for a FAN_REPORT_DFID_FID
> support.

@Amir could you please look at this fanotify14.c failure on 5.4.241-rc1?

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [LTP] [PATCH 5.4 00/92] 5.4.241-rc1 review
  2023-04-21  8:04     ` Petr Vorel
@ 2023-04-24  6:36       ` Yang Xu (Fujitsu)
  0 siblings, 0 replies; 4+ messages in thread
From: Yang Xu (Fujitsu) @ 2023-04-24  6:36 UTC (permalink / raw)
  To: Petr Vorel, Cyril Hrubis
  Cc: shuah@kernel.org, f.fainelli@gmail.com, Arnd Bergmann,
	rwarsow@gmx.de, pavel@denx.de, Greg Kroah-Hartman, LTP List,
	patches@lists.linux.dev, stable@vger.kernel.org,
	linux-kernel@vger.kernel.org, lkft-triage@lists.linaro.org,
	srw@sladewatkins.net, patches@kernelci.org,
	akpm@linux-foundation.org, jonathanh@nvidia.com,
	torvalds@linux-foundation.org, sudipm.mukherjee@gmail.com,
	linux@roeck-us.net


on 2023/04/21 16:04, Petr Vorel wrote:
>> Hi!
>>>> This is the start of the stable review cycle for the 5.4.241 release.
>>>> There are 92 patches in this series, all will be posted as a response
>>>> to this one.  If anyone has any issues with these being applied, please
>>>> let me know.
> 
>>>> Responses should be made by Thu, 20 Apr 2023 12:02:44 +0000.
>>>> Anything received after that time might be too late.
> 
>>>> The whole patch series can be found in one patch at:
>>>>          https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.241-rc1.gz
>>>> or in the git tree and branch at:
>>>>          git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y
>>>> and the diffstat can be found below.
> 
>>>> thanks,
> 
>>>> greg k-h
> 
> 
>>> Recently we have upgraded the LTP test suite version and started noticing
>>> these test failures on 5.4.
>>> Test getting skipped on 4.19 and 4.14 as not supported features.
> 
>>> Need to investigate test case issues or kernel issues.
> 
>>> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> 
>>> NOTE:
> 
>>> ---
>>> creat09.c:73: TINFO: User nobody: uid = 65534, gid = 65534
>>> creat09.c:75: TINFO: Found unused GID 11: SUCCESS (0)
>>> creat09.c:120: TINFO: File created with umask(0)
>>> creat09.c:106: TPASS: mntpoint/testdir/creat.tmp: Owned by correct group
>>> creat09.c:112: TPASS: mntpoint/testdir/creat.tmp: Setgid bit not set
>>> creat09.c:106: TPASS: mntpoint/testdir/open.tmp: Owned by correct group
>>> creat09.c:112: TPASS: mntpoint/testdir/open.tmp: Setgid bit not set
>>> creat09.c:120: TINFO: File created with umask(S_IXGRP)
>>> creat09.c:106: TPASS: mntpoint/testdir/creat.tmp: Owned by correct group
>>> creat09.c:110: TFAIL: mntpoint/testdir/creat.tmp: Setgid bit is set
>>> creat09.c:106: TPASS: mntpoint/testdir/open.tmp: Owned by correct group
>>> creat09.c:110: TFAIL: mntpoint/testdir/open.tmp: Setgid bit is set
> 
>>> Test history links,
>>>   - https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-5.4.y/build/v5.4.238-199-g230f1bde44b6/testrun/16338751/suite/ltp-syscalls/test/creat09/history/
>>>   - https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-5.4.y/build/v5.4.238-199-g230f1bde44b6/testrun/16337895/suite/ltp-cve/test/cve-2018-13405/history/
>>>   - https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-5.4.y/build/v5.4.238-199-g230f1bde44b6/testrun/16338751/suite/ltp-syscalls/test/creat09/log
> 
>> That's likely a missing kernel patch, as this is a regression test there
>> should have been links to the patches and CVE referencies in the test
>> output as the test is tagged with kernel commits and CVE numbers:
> 
>>          .tags = (const struct tst_tag[]) {
>>                  {"linux-git", "0fa3ecd87848"},
>>                  {"CVE", "2018-13405"},
>>                  {"CVE", "2021-4037"},
>>                  {"linux-git", "01ea173e103e"},
> Only this one has been backported (as
> e76bd6da51235ce86f5a8017dd6c056c76da64f9), the other two are missing.
>>                  {"linux-git", "1639a49ccdce"},
>>                  {"linux-git", "426b4ca2d6a5"},
> The last one is merge tag, I wonder if it's correct:
> 426b4ca2d6a5 ("Merge tag 'fs.setgid.v6.0' of git://git.kernel.org/pub/scm/linux/kernel/git/brauner/linux")
> Maybe just 1639a49ccdce would be ok.
> 
> @Yang Xu
> 1) why 1639a49ccdce has not been merged to stable tree? It does not apply now,
> was that the only reason? Or is it not applicable?

In fact, I don't know the stable kernel tree details.

> 
> @Yang Xu is really 426b4ca2d6a5 needed? Was it easier to list merge commit than
> particular fixes? Merge commit contains:
> 
> 5fadbd992996 ("ceph: rely on vfs for setgid stripping")
> 1639a49ccdce ("fs: move S_ISGID stripping into the vfs_*() helpers")
> ac6800e279a2 ("fs: Add missing umask strip in vfs_tmpfile")
> 2b3416ceff5e ("fs: add mode_strip_sgid() helper")

We just need 1639a49ccdce commit is ok and this commit will depend on 
2b3416ceff5e because the previous commit needs to use  mode_strip_sgid api.

For the merged commit, we have a disscussion for 5.19 or 6.0 with cyril 
on last year
see url 
https://lore.kernel.org/ltp/1663143142-2283-1-git-send-email-xuyang2018.jy@fujitsu.com/T/#t

> 
> They have not been backported to 5.4 stable, nor to the older releases.
> Again, they don't apply.
> 

I don't have attention to stable kernel tree, maybe we can ask 5.14 
stable maintainer?

Best Regards
Yang Xu
> 
>>                  {}
>>          },
> 
>>> ---
> 
>>> fanotify14.c:161: TCONF: FAN_REPORT_TARGET_FID not supported in kernel?
>>> fanotify14.c:157: TINFO: Test case 7: fanotify_init(FAN_CLASS_NOTIF |
>>> FAN_REPORT_TARGET_FID | FAN_REPORT_DFID_FID, O_RDONLY)
>>> fanotify14.c:161: TCONF: FAN_REPORT_TARGET_FID not supported in kernel?
>>> [  377.081993] EXT4-fs (loop0): mounting ext3 file system using the
>>> ext4 subsystem
>>> fanotify14.c:157: TINFO: Test case 8: fanotify_init(FAN_CLASS_NOTIF |
>>> FAN_REPORT_DFID_FID, O_RDONLY)
>>> [  377.099137] EXT4-fs (loop0): mounted filesystem with ordered data
>>> mode. Opts: (null)
>>> fanotify14.c:175: TFAIL: fanotify_init(tc->init.flags, O_RDONLY)
>>> failed: EINVAL (22)
> 
>> Possibly like the test may be missing check for a FAN_REPORT_DFID_FID
>> support.
> 
> @Amir could you please look at this fanotify14.c failure on 5.4.241-rc1?
> 
> Kind regards,
> Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-04-24  6:36 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20230418120304.658273364@linuxfoundation.org>
2023-04-19  7:41 ` [LTP] [PATCH 5.4 00/92] 5.4.241-rc1 review Naresh Kamboju
2023-04-19  7:58   ` Cyril Hrubis
2023-04-21  8:04     ` Petr Vorel
2023-04-24  6:36       ` Yang Xu (Fujitsu)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).