From: Cyril Hrubis <chrubis@suse.cz>
To: Martin Doucha <mdoucha@suse.cz>
Cc: ltp@lists.linux.it, nstange@suse.de
Subject: Re: [LTP] [PATCH 1/5] KVM: Add helper functions for accessing GDT/LDT
Date: Wed, 26 Apr 2023 11:20:54 +0200 [thread overview]
Message-ID: <ZEjs9vdLhq15e1T2@rei> (raw)
In-Reply-To: <5caf6d8e-e58c-0cb4-bc46-1a0d8dc56190@suse.cz>
Hi!
> > I did have a look at the patchset and I do not see anything wrong, but I
> > cannot really review the code without spending a weeks reading the AMD
> > CPU manuals. What about sending v2 with the runtest file change and
> > CCing the x86@kernel.org mailing list? Hopefully some of the kernel devs
> > on that list will have a bit of time to check the actual correctness of
> > the code...
>
> I've CC'd Nicolai who wrote the original KVM tests. If he approves, I'd
> say it'd good enough to merge. I've tested the code on AMD machines and
> it works and successfully reproduces the CVE on affected kernels.
Fair enough, Nikoai can you add you Reviewed-by?
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2023-04-26 9:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-21 14:57 [LTP] [PATCH 1/5] KVM: Add helper functions for accessing GDT/LDT Martin Doucha
2023-04-21 14:57 ` [LTP] [PATCH 2/5] KVM: Add helper function for reading x86 segment registers Martin Doucha
2023-05-02 14:24 ` Petr Vorel
2023-04-21 14:57 ` [LTP] [PATCH 3/5] KVM: Fix infinite loop in ptr2hex() Martin Doucha
2023-04-26 7:57 ` Cyril Hrubis
2023-04-26 8:09 ` Martin Doucha
2023-05-02 14:26 ` Petr Vorel
2023-05-02 19:46 ` Petr Vorel
2023-04-21 14:57 ` [LTP] [PATCH 4/5] Add KVM helper functions for AMD SVM Martin Doucha
2023-05-02 14:29 ` Petr Vorel
2023-04-21 14:57 ` [LTP] [PATCH 5/5] Add test for CVE 2021-3653 Martin Doucha
2023-04-24 9:09 ` Martin Doucha
2023-05-02 14:32 ` Petr Vorel
2023-05-03 12:42 ` Petr Vorel
2023-04-25 12:48 ` Petr Vorel
2023-04-26 8:08 ` [LTP] [PATCH 1/5] KVM: Add helper functions for accessing GDT/LDT Cyril Hrubis
2023-04-26 9:19 ` Martin Doucha
2023-04-26 9:20 ` Cyril Hrubis [this message]
2023-05-02 14:24 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZEjs9vdLhq15e1T2@rei \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=mdoucha@suse.cz \
--cc=nstange@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox