Re: [LTP] [PATCH] syscalls/statx06: use a fine-grained timestamp for the second time fetch

[Cyril Hrubis <chrubis@suse.cz>]

Hi!
> > Now, it is not a right time to review this patch,  I prefer to review 
> > this when your kernel patchset is merged into linux master or 
> > linux-next. Then we can add a comment or a kernel commit id to explain 
> > this..
> > 
> > 
> 
> Fair enough. I don't think there is any issue with taking this patch in
> earlier however.
> 
> The problem with this test is that it makes the assumption that coarse-
> grained timestamps are sufficient to bracket a filesystem operation.
> While that has largely been true in the past, it's certainly not
> specified by any standard.

Do we have any API to ask the kernel what the granularity of filesystem
the timestamps is? Would that make sense to be added if it's not
present?

Apart from that I think that this patch is fine, since the
CLOCK_REALTIME value would be between CLOCK_REALTIME_COARSE and
CLOCK_REALTIME_COARSE + one tick. So the change is backward compatible
and we will not loose any precision in the assertions either.

Reviewed-by: Cyril Hrubis <chrubis@suse.cz>

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp