public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: Martin Doucha <mdoucha@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2 1/1] runtest/cve: Add some existing CVE tests to runtest file
Date: Wed, 21 Jun 2023 14:52:53 +0200	[thread overview]
Message-ID: <ZJLypX9iZ8n-SJJy@yuki> (raw)
In-Reply-To: <e6dc2fff-99cc-33ff-548e-1828143d9d74@suse.cz>

Hi!
> > Thanks for the info. I look a while why can't build them
> > as fake programs and only exit with TCONF on non-x86,
> > but seems it has some platform-dependent assembly language
> > and the linker rule unsupport that.
> 
> The KVM Makefile is complicated because we build a raw machine code 
> binary which will be executed in the VM and then link it inside the test 
> program as a data blob. Adding extra conditions to skip the blob 
> compilation and safely TCONF in the test programs would make everything 
> even more complicated so it's not worth the effort at this point because 
> the KVM test coverage is still quite small.

I guess that proper solution could be implemented in the new generation
LTP executor. For instance if these tests have arch tag in tst_test set
to x86_64 the executor can read the metadata and wouldn't even attempt
to run these tests.

The whole point of the metadata parsing is to make the test execution
more flexible, since the runtest file based approach does not scale and
was outdated even ten years ago...

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

      reply	other threads:[~2023-06-21 12:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-20  8:03 [LTP] [PATCH v1 1/1] runtest/cve: Add some existing CVE tests to runtest file Souta Kawahara
2023-06-20  8:34 ` Li Wang
2023-06-20 21:08   ` Petr Vorel
2023-06-21  0:19     ` 河原颯太
2023-06-21  0:20 ` [LTP] [PATCH v2 " Souta Kawahara
2023-06-21  2:37   ` Li Wang
2023-06-21  9:07   ` Martin Doucha
2023-06-21 11:52     ` Li Wang
2023-06-21 12:41       ` Martin Doucha
2023-06-21 12:52         ` Cyril Hrubis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZJLypX9iZ8n-SJJy@yuki \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    --cc=mdoucha@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox