From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 668BFEB64D9 for ; Tue, 4 Jul 2023 08:46:22 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 7BDC43CC036 for ; Tue, 4 Jul 2023 10:46:20 +0200 (CEST) Received: from in-2.smtp.seeweb.it (in-2.smtp.seeweb.it [217.194.8.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 0528E3CC02A for ; Tue, 4 Jul 2023 10:46:09 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-2.smtp.seeweb.it (Postfix) with ESMTPS id C94006008A6 for ; Tue, 4 Jul 2023 10:46:07 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 404AF225D9; Tue, 4 Jul 2023 08:46:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1688460367; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zK9LxSc7FeLutRivgZueSu0rFxNxohiGhudHsmaruSg=; b=CEpVLSwoAQInbiIQNntJs6gVOlJHNM+c6NEnMl++RA0YVHxPs0MwFqEFakgQGOhcXJs+jU xVtQMBXT40v9z6/ckvnP744qgaGlZIeE7IdZJIvNQJcRSQGSyJyCzOE5znz6HxdY0oEPmj QBuiHqwP82n12aetcSJ9EAf85o5u/uk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1688460367; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zK9LxSc7FeLutRivgZueSu0rFxNxohiGhudHsmaruSg=; b=QEteH8A5y4ATY5LTjMpq0B8ZFlJoqJl7zA41LYKB0pbVdVXoiWedHuMkH5hdOxIau+rc4w Ab9Q6t10tfofqPCw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2C27C133F7; Tue, 4 Jul 2023 08:46:07 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id wVC4CE/co2RrNwAAMHmgww (envelope-from ); Tue, 04 Jul 2023 08:46:07 +0000 Date: Tue, 4 Jul 2023 10:47:12 +0200 From: Cyril Hrubis To: Petr Vorel Message-ID: References: <20230703194904.445661-1-pvorel@suse.cz> <20230703200735.GB446620@pevik> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230703200735.GB446620@pevik> X-Virus-Scanned: clamav-milter 1.0.1 at in-2.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH 1/1] mremap06: Add mremap() reproducer for 7e7757876f25 X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! > > @Cyril: I plan to add SAFE_FALLOCATE() (3 other sources), > > SAFE_MPROTECT() (7 other sources) and SAFE_MREMAP() > > (2 other sources), but as a separate effort. > > @Jan, you added in 9120d8a22 ("safe_macros: turn functions with off_t parameter > into static inline") note "following functions are inline because the behaviour > may depend on -D_FILE_OFFSET_BITS=64 -DOFF_T=__off64_t compile flags". IMHO the > only source which uses SAFE_MMAP() is testcases/kernel/mem/mmapstress/mmapstress01.c > I'm asking because I wonder if SAFE_MPROTECT() and SAFE_MREMAP() should be also > static inline, IMHO it's not needed. As long as the return value or function parameters does not include off_t it's not needed. > @all: SAFE_MPROTECT() would be needed also on some still old API sources > (testcases/kernel/syscalls/signal/signal06.c, > testcases/kernel/syscalls/mprotect/mprotect02.c, > testcases/kernel/syscalls/mprotect/mprotect03.c) > Should I ignore that and add it just to new API? Just add it to the new API, the old test should be cleaned up and converted anyways. -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp