From: Cyril Hrubis <chrubis@suse.cz>
To: Li Wang <liwang@redhat.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [RFC PATCH 1/3] Makefile: Add C header with generated LTP version
Date: Fri, 14 Jul 2023 08:46:37 +0200 [thread overview]
Message-ID: <ZLDvTYhGI6_Q5vDE@yuki> (raw)
In-Reply-To: <CAEemH2eE8PUY_at7C-aUX+75ALdM-jjm71L=M-ETYc94RKJFcg@mail.gmail.com>
Hi!
> So why not use the script to append that one line in tst_test.h directly?
That wouldn't play nice with development, you would have to make sure
not to accidentally commit the line, which would happen way to often.
> The ltp-version.h looks quite redundant and we could even put this script
> into build.sh together, IMHO.
The end goal here is to have the LTP version in the test output
regardless where it came from (tarball, git) and how it was compiled
(build.sh, cd testcases/kernel/ && make, ...). The only way how to do
this is to refresh the version on each make and build it from inside the
library.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2023-07-14 6:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-04 9:19 [LTP] [RFC PATCH 1/3] Makefile: Add C header with generated LTP version Petr Vorel
2023-07-04 9:19 ` Petr Vorel
2023-07-04 9:25 ` Petr Vorel
2023-07-13 11:58 ` Cyril Hrubis
2023-07-14 2:54 ` Li Wang
2023-07-14 4:53 ` Petr Vorel
2023-07-14 6:46 ` Cyril Hrubis [this message]
2023-07-14 9:25 ` Li Wang
2023-07-04 9:19 ` [LTP] [RFC PATCH 2/3] lib/C-API: Add option -V to print " Petr Vorel
2023-07-04 10:33 ` Cyril Hrubis
2023-07-04 11:50 ` Petr Vorel
2023-07-04 12:04 ` Cyril Hrubis
2023-07-04 12:07 ` Petr Vorel
2023-07-04 9:19 ` [LTP] [RFC PATCH 3/3] lib/C-API: Print LTP version at test start Petr Vorel
2023-07-04 9:26 ` [LTP] [RFC PATCH 1/3] Makefile: Add C header with generated LTP version Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLDvTYhGI6_Q5vDE@yuki \
--to=chrubis@suse.cz \
--cc=liwang@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox