public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: Petr Vorel <pvorel@suse.cz>
Cc: Fabian Vogt <fvogt@suse.com>, Jiri Slaby <jirislaby@kernel.org>,
	Vlastimil Babka <vbabka@suse.cz>,
	ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2 1/1] mremap06: Add mremap() reproducer for 7e7757876f25
Date: Tue, 18 Jul 2023 17:02:39 +0200	[thread overview]
Message-ID: <ZLapjxuvD2KkQHi0@yuki> (raw)
In-Reply-To: <20230717094348.1105467-1-pvorel@suse.cz>

Hi!
> +	ret = fallocate(fd, 0, 0, mmap_size);
> +	if (ret == -1)
> +		tst_brk(TBROK, "fallocate() failed");

I'm slightly surprised that we do not have SAFE_FALLOCATE().

Anyways:

Reviewed-by: Cyril Hrubis <chrubis@suse.cz>

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  parent reply	other threads:[~2023-07-18 15:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-17  9:43 [LTP] [PATCH v2 1/1] mremap06: Add mremap() reproducer for 7e7757876f25 Petr Vorel
2023-07-18  8:33 ` Vlastimil Babka
2023-07-18 15:02 ` Cyril Hrubis [this message]
2023-07-19  9:54   ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZLapjxuvD2KkQHi0@yuki \
    --to=chrubis@suse.cz \
    --cc=fvogt@suse.com \
    --cc=jirislaby@kernel.org \
    --cc=ltp@lists.linux.it \
    --cc=pvorel@suse.cz \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox