From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CE479C001DB for ; Fri, 4 Aug 2023 09:19:22 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 8F7B03CD497 for ; Fri, 4 Aug 2023 11:19:20 +0200 (CEST) Received: from in-2.smtp.seeweb.it (in-2.smtp.seeweb.it [217.194.8.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id E68643CB125 for ; Fri, 4 Aug 2023 11:19:09 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-2.smtp.seeweb.it (Postfix) with ESMTPS id 2EA1660118E for ; Fri, 4 Aug 2023 11:19:08 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 0C17B1F8AC; Fri, 4 Aug 2023 09:19:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1691140747; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/cz5yXTnSTYkgDFcmFMqhqP6onev/u7yh71bXUCPQ4w=; b=1ylgJYGRSgMO9laAjRzk8e7ClVqLLoaSFpH5N83PyTzFnytszm0ArgqjvogVCeHq8jKADK mbvVq6sw2Pm6DcMDyxGRcHDCDlSok8g9EFcQaiWgmdsMlnkz3frw+c6QBDa4FZm820I84Q J6oaXJgSNnwecrhqnyseJb0MO/HJk/E= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1691140747; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/cz5yXTnSTYkgDFcmFMqhqP6onev/u7yh71bXUCPQ4w=; b=So4nUOE8PHFQVWbsq/7I/BTvlTYUWqC2R0BQZcbm1/Bvh+CEGksQuhT6+9AN3HfvSElzeQ lsnfkJgUIBD/o9AA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id ED57413904; Fri, 4 Aug 2023 09:19:06 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ax3cN4rCzGTKEgAAMHmgww (envelope-from ); Fri, 04 Aug 2023 09:19:06 +0000 Date: Fri, 4 Aug 2023 11:20:03 +0200 From: Cyril Hrubis To: Avinesh Kumar Message-ID: References: <20230804053022.22008-1-akumar@suse.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230804053022.22008-1-akumar@suse.de> X-Virus-Scanned: clamav-milter 1.0.1 at in-2.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH] syscalls/pipe08: Rewrite test using new LTP API X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! > +static int pipefd[2]; > +static int sigpipe_cnt; I've changed this to volatile int in order to avoid miscompilation and pushed, thanks. Side note, anything that is changed asynchronously from a signal handler is better to be declared volatile in order to avoid compiler from assuming it's value, as the compiler does not understand that execution flow can jump into a signal handler. -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp