public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: Yang Xu <xuyang2018.jy@fujitsu.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v3 1/3] syscalls/setgroups01: Convert to new API
Date: Mon, 14 Aug 2023 16:05:49 +0200	[thread overview]
Message-ID: <ZNo0vT2TwzqZYmZ3@yuki> (raw)
In-Reply-To: <1692012648-1970-1-git-send-email-xuyang2018.jy@fujitsu.com>

Hi!
The original test used the getgroups syscall to get the list of groups
and its size. I've changed the code to match the behavior and pushed,
thanks.

Diff:
diff --git a/testcases/kernel/syscalls/setgroups/setgroups01.c b/testcases/kernel/syscalls/setgroups/setgroups01.c
index ca01997ae..9a5b77e93 100644
--- a/testcases/kernel/syscalls/setgroups/setgroups01.c
+++ b/testcases/kernel/syscalls/setgroups/setgroups01.c
@@ -27,7 +27,8 @@ static void verify_setgroups(void)
 
 static void setup(void)
 {
-       if (GETGROUPS(len, list) < 0)
+       len = GETGROUPS(NGROUPS, list);
+       if (len < 0)
                tst_brk(TBROK | TERRNO, "getgroups() Failed");
 }

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

      parent reply	other threads:[~2023-08-14 14:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-14 11:30 [LTP] [PATCH v3 1/3] syscalls/setgroups01: Convert to new API Yang Xu
2023-08-14 11:30 ` [LTP] [PATCH v3 2/3] syscalls/setgroups02: " Yang Xu
2023-08-14 14:15   ` Cyril Hrubis
2023-08-14 11:30 ` [LTP] [PATCH v3 3/3] syscalls/setgroups03: " Yang Xu
2023-08-14 14:49   ` Cyril Hrubis
2023-08-14 14:05 ` Cyril Hrubis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZNo0vT2TwzqZYmZ3@yuki \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    --cc=xuyang2018.jy@fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox