From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F01FFC6FA8F for ; Tue, 29 Aug 2023 09:00:30 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 4F9373CE060 for ; Tue, 29 Aug 2023 11:00:24 +0200 (CEST) Received: from in-7.smtp.seeweb.it (in-7.smtp.seeweb.it [217.194.8.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id C25813C98FC for ; Tue, 29 Aug 2023 11:00:09 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-7.smtp.seeweb.it (Postfix) with ESMTPS id 4DF82200D05 for ; Tue, 29 Aug 2023 11:00:08 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 9D2DB1F37E; Tue, 29 Aug 2023 09:00:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1693299608; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=drbkVc2ZkYf6+jnnrjz8W7Zda07O5wcGC4jsEIDB5rs=; b=xpoPjI1e+G1iBBJNWJi4OKWHIdwjTc+D7IFGmti4/lkGaBJfADfoVyOTa4uW5V8S3DWc9D quw5P+ZykBPEF35TV4whV3TIvzzRTM2MwEPnfzhxlXS64y7V6gIOcmQp1lXnAfJJKknZUA tnXXVff8GusNnQMUm8hptfjZPLgDUOQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1693299608; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=drbkVc2ZkYf6+jnnrjz8W7Zda07O5wcGC4jsEIDB5rs=; b=zXKJNW/qZwYJpsvTcRdAaPRtr84GLtl0t4E006oSq3aNJjpQurpToooPhFDPTDhTNc5OCZ PM6TJopOfHNI6LCg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4B1A213301; Tue, 29 Aug 2023 09:00:08 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id s/FjBpiz7WT6TAAAMHmgww (envelope-from ); Tue, 29 Aug 2023 09:00:08 +0000 Date: Tue, 29 Aug 2023 10:59:49 +0200 From: Cyril Hrubis To: Avinesh Kumar Message-ID: References: <20230818112023.18159-1-akumar@suse.de> <20230818112023.18159-2-akumar@suse.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230818112023.18159-2-akumar@suse.de> X-Virus-Scanned: clamav-milter 1.0.1 at in-7.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH 2/4] syscalls/mmap01: Rewrite the test using new LTP API X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! > + if (system(cmd_buffer) != 0) > + tst_res(TPASS, "mmap() functionality successful"); > + else > + tst_res(TFAIL, "mmap() functionality failed"); This is quite ugly. Can we please instead for a child process and run a function that reads the file with read() and checks the data? -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp