From: Cyril Hrubis <chrubis@suse.cz>
To: Avinesh Kumar <akumar@suse.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 4/4] syscalls/mmap04: Rewrite the test using new LTP API
Date: Tue, 29 Aug 2023 12:03:46 +0200 [thread overview]
Message-ID: <ZO3CghC11RzXJjuq@rei> (raw)
In-Reply-To: <20230818112023.18159-4-akumar@suse.de>
Hi!
This is nearly identical to the mmap02.c and the same comments apply
here.
Also the test does not check the PROT_EXEC part at all. If we wanted to
properly test PROT_EXEC we would have to copy a function code to the
file first then execute it, something that mprotect04 does, but since
that flag is already tested in mprotect04 it does not make that much
sense to have it here as well.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2023-08-29 10:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-18 11:20 [LTP] [PATCH 1/4] lib: Add SAFE_CALLOC() helper function to LTP library Avinesh Kumar
2023-08-18 11:20 ` [LTP] [PATCH 2/4] syscalls/mmap01: Rewrite the test using new LTP API Avinesh Kumar
2023-08-29 8:59 ` Cyril Hrubis
2023-08-18 11:20 ` [LTP] [PATCH 3/4] syscalls/mmap02: " Avinesh Kumar
2023-08-29 9:07 ` Cyril Hrubis
2023-08-18 11:20 ` [LTP] [PATCH 4/4] syscalls/mmap04: " Avinesh Kumar
2023-08-29 10:03 ` Cyril Hrubis [this message]
2023-09-01 12:13 ` Avinesh Kumar
2023-09-01 12:28 ` Cyril Hrubis
2023-09-05 9:54 ` [LTP] [PATCH] syscalls/mmap04: Validate mapping perms in /proc/self/maps Avinesh Kumar
2023-09-14 15:14 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZO3CghC11RzXJjuq@rei \
--to=chrubis@suse.cz \
--cc=akumar@suse.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox