Linux Test Project
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: Yang Xu <xuyang2018.jy@fujitsu.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2 1/2] syscalls/faccessat01: Convert to new API
Date: Wed, 23 Aug 2023 16:28:32 +0200	[thread overview]
Message-ID: <ZOYXkEahxyqfGNQd@yuki> (raw)
In-Reply-To: <1692617755-32627-1-git-send-email-xuyang2018.jy@fujitsu.com>

Hi!
> +static struct tst_test test = {
> +	.test = verify_faccessat,
> +	.tcnt = ARRAY_SIZE(tcases),
> +	.setup = setup,
> +	.cleanup = cleanup,
> +	.bufs = (struct tst_buffers []) {
> +		{&test_file, .str = TESTFILE},
> +		{&abs_path, .size = sizeof(char)},
                   ^
		   I've removed this line, since we allocate the
		   abs_path dynamically in the test setup and pushed
		   both patches, thanks.

> +		{&file_path, .str = FILEPATH},
> +		{},
> +	},
> +	.needs_tmpdir = 1,
> +};
> -- 
> 2.39.1
> 
> 
> -- 
> Mailing list info: https://lists.linux.it/listinfo/ltp

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

      parent reply	other threads:[~2023-08-23 14:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-21 11:35 [LTP] [PATCH v2 1/2] syscalls/faccessat01: Convert to new API Yang Xu
2023-08-21 11:35 ` [LTP] [PATCH v2 2/2] syscalls/faccessat02: Move errnos check to faccessat02 Yang Xu
2023-08-23 14:28 ` Cyril Hrubis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZOYXkEahxyqfGNQd@yuki \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    --cc=xuyang2018.jy@fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox