Re: [LTP] [RFC PATCH 2/2] hugemmap33: Test to detect bug with migrating gigantic pages

[Cyril Hrubis <chrubis@suse.cz>]

Hi!
> > > +     if (tst_taint_check())
> > > +             tst_res(TFAIL, "Test resulted in kernel tainted");
> > > +     else
> > > +             tst_res(TPASS, "Test completed successfully");
> >
> > tst_test.taint_check ?
> >
> 
> We have to keep these check sentences otherwise it will
> complain with no reporting results.
> 
>   tst_hugepage.c:103: TINFO: 2 hugepage(s) reserved
>   tst_test.c:1562: TINFO: Timeout per run is 0h 01m 30s
>   hugemmap34.c:107: TINFO: Runtime exhausted, exiting
>   tst_test.c:1394: TBROK: Test haven't reported results!

Right the .taint_check only produces TFAIL when kernel taint flags
change during the duration of the test.

We can as well do the same as we do in most of the CVE tests that have
this line at the end of the run() function:

tst_res(TPASS, "Nothing bad happened, probably.");

Or we can keep the tst_taint_check() in the code, but I guess that we
are missing tst_taint_init() in the test setup(), or am I mistaken?

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp