From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 419D1EE7FF4 for ; Mon, 11 Sep 2023 08:11:18 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 6FA293CC126 for ; Mon, 11 Sep 2023 10:11:17 +0200 (CEST) Received: from in-2.smtp.seeweb.it (in-2.smtp.seeweb.it [217.194.8.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 6EDC93CB383 for ; Mon, 11 Sep 2023 10:11:07 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-2.smtp.seeweb.it (Postfix) with ESMTPS id C9C40601463 for ; Mon, 11 Sep 2023 10:11:06 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 40B8C211C3; Mon, 11 Sep 2023 08:11:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1694419865; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=v/XA6RWrkX5Nuz6Bi63EUf8SnjabX0jGPBn2MJ3D4GE=; b=EPQtd3UY90XAijT3CXrgwph3qLcy2j1x5x2pBFBj24PT8MnJ6Q7FtvfZVAofd6/H0gL4+f JYddZec0W/qbLQpGBEbRyeSgDtG6kByZx4MNOXb0FVC2j9QJB4Emm8vZ80DPIypsP3+I2c cykI9Enoq7Nui5a5vlzL3yLXUCV4iwM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1694419865; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=v/XA6RWrkX5Nuz6Bi63EUf8SnjabX0jGPBn2MJ3D4GE=; b=WJMD+cJ0Az3H3lUdQKNzBptlkKQJW8NPg39aUqE6jYp/37imj/A0lZ7aDxGT8AlHeAAiI5 wg+ib1k5oPnwkRBA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 27FBD139CC; Mon, 11 Sep 2023 08:11:05 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 8ADQCJnL/mRzfAAAMHmgww (envelope-from ); Mon, 11 Sep 2023 08:11:05 +0000 Date: Mon, 11 Sep 2023 10:11:49 +0200 From: Cyril Hrubis To: Li Wang Message-ID: References: <20230524093930.43971-1-liwang@redhat.com> <20230524093930.43971-2-liwang@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Virus-Scanned: clamav-milter 1.0.1 at in-2.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [RFC PATCH 2/2] hugemmap33: Test to detect bug with migrating gigantic pages X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! > > > + if (tst_taint_check()) > > > + tst_res(TFAIL, "Test resulted in kernel tainted"); > > > + else > > > + tst_res(TPASS, "Test completed successfully"); > > > > tst_test.taint_check ? > > > > We have to keep these check sentences otherwise it will > complain with no reporting results. > > tst_hugepage.c:103: TINFO: 2 hugepage(s) reserved > tst_test.c:1562: TINFO: Timeout per run is 0h 01m 30s > hugemmap34.c:107: TINFO: Runtime exhausted, exiting > tst_test.c:1394: TBROK: Test haven't reported results! Right the .taint_check only produces TFAIL when kernel taint flags change during the duration of the test. We can as well do the same as we do in most of the CVE tests that have this line at the end of the run() function: tst_res(TPASS, "Nothing bad happened, probably."); Or we can keep the tst_taint_check() in the code, but I guess that we are missing tst_taint_init() in the test setup(), or am I mistaken? -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp