* [LTP] [PATCH] stress/udp/multi-diffip: bugfix for multi-diffip/udp4-multi-diffip01 @ 2023-09-14 18:22 Li Min via ltp 2023-09-13 12:01 ` Andrea Cervesato via ltp 2023-09-14 12:27 ` Cyril Hrubis 0 siblings, 2 replies; 3+ messages in thread From: Li Min via ltp @ 2023-09-14 18:22 UTC (permalink / raw) To: ltp udp4-multi-diffip01: line 233: ret: unbound variable Signed-off-by: Min Li <limin154@huawei.com> --- testcases/network/stress/udp/multi-diffip/udp4-multi-diffip01 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/testcases/network/stress/udp/multi-diffip/udp4-multi-diffip01 b/testcases/network/stress/udp/multi-diffip/udp4-multi-diffip01 index 92af9e438..c0d50efaf 100644 --- a/testcases/network/stress/udp/multi-diffip/udp4-multi-diffip01 +++ b/testcases/network/stress/udp/multi-diffip/udp4-multi-diffip01 @@ -230,7 +230,7 @@ while [ $ipaddr_pair_num -lt $IP_TOTAL_FOR_TCPIP ]; do # Set IPv6 addresses to the interfaces ip addr add ${lhost_addr}/${network_mask} dev $lhost_ifname - if [ $ret -eq 2 ]; then + if [ $? -eq 2 ]; then ip addr del ${lhost_addr}/${network_mask} dev $lhost_ifname 2>&1 ip addr add ${lhost_addr}/${network_mask} dev $lhost_ifname fi -- 2.33.0 -- Mailing list info: https://lists.linux.it/listinfo/ltp ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [LTP] [PATCH] stress/udp/multi-diffip: bugfix for multi-diffip/udp4-multi-diffip01 2023-09-14 18:22 [LTP] [PATCH] stress/udp/multi-diffip: bugfix for multi-diffip/udp4-multi-diffip01 Li Min via ltp @ 2023-09-13 12:01 ` Andrea Cervesato via ltp 2023-09-14 12:27 ` Cyril Hrubis 1 sibling, 0 replies; 3+ messages in thread From: Andrea Cervesato via ltp @ 2023-09-13 12:01 UTC (permalink / raw) To: ltp Hi! Thanks for catching this bug. It will be pushed by maintainers according with LTP release code freeze time. Reviewed-by: Andrea Cervesato <andrea.cervesato@suse.com> Best regards, Andrea Cervesato On 9/14/23 20:22, Li Min via ltp wrote: > udp4-multi-diffip01: line 233: ret: unbound variable > > Signed-off-by: Min Li <limin154@huawei.com> > --- > testcases/network/stress/udp/multi-diffip/udp4-multi-diffip01 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/testcases/network/stress/udp/multi-diffip/udp4-multi-diffip01 b/testcases/network/stress/udp/multi-diffip/udp4-multi-diffip01 > index 92af9e438..c0d50efaf 100644 > --- a/testcases/network/stress/udp/multi-diffip/udp4-multi-diffip01 > +++ b/testcases/network/stress/udp/multi-diffip/udp4-multi-diffip01 > @@ -230,7 +230,7 @@ while [ $ipaddr_pair_num -lt $IP_TOTAL_FOR_TCPIP ]; do > # Set IPv6 addresses to the interfaces > ip addr add ${lhost_addr}/${network_mask} dev $lhost_ifname > > - if [ $ret -eq 2 ]; then > + if [ $? -eq 2 ]; then > ip addr del ${lhost_addr}/${network_mask} dev $lhost_ifname 2>&1 > ip addr add ${lhost_addr}/${network_mask} dev $lhost_ifname > fi > -- > 2.33.0 > > -- Mailing list info: https://lists.linux.it/listinfo/ltp ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [LTP] [PATCH] stress/udp/multi-diffip: bugfix for multi-diffip/udp4-multi-diffip01 2023-09-14 18:22 [LTP] [PATCH] stress/udp/multi-diffip: bugfix for multi-diffip/udp4-multi-diffip01 Li Min via ltp 2023-09-13 12:01 ` Andrea Cervesato via ltp @ 2023-09-14 12:27 ` Cyril Hrubis 1 sibling, 0 replies; 3+ messages in thread From: Cyril Hrubis @ 2023-09-14 12:27 UTC (permalink / raw) To: Li Min; +Cc: ltp Hi! Applied, thanks. -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-09-14 12:26 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-09-14 18:22 [LTP] [PATCH] stress/udp/multi-diffip: bugfix for multi-diffip/udp4-multi-diffip01 Li Min via ltp 2023-09-13 12:01 ` Andrea Cervesato via ltp 2023-09-14 12:27 ` Cyril Hrubis
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox