[LTP] [PATCH v1] Replace runltp-ng with kirk framework

[LTP] [PATCH v1] Replace runltp-ng with kirk framework

[Andrea Cervesato]

From: Andrea Cervesato <andrea.cervesato@suse.com>

Kirk application is a fork of runltp-ng and it aims to merge multiple
Linux testing frameworks in one tool, providing support for remote
testing via Qemu, SSH, LTX, parallel execution and much more.

Signed-off-by: Andrea Cervesato <andrea.cervesato@suse.com>
---
 .gitmodules     | 6 +++---
 tools/kirk      | 1 +
 tools/runltp-ng | 1 -
 3 files changed, 4 insertions(+), 4 deletions(-)
 create mode 160000 tools/kirk
 delete mode 160000 tools/runltp-ng

diff --git a/.gitmodules b/.gitmodules
index d1d558b9e..088023039 100644
--- a/.gitmodules
+++ b/.gitmodules
@@ -4,6 +4,6 @@
 [submodule "tools/sparse/sparse-src"]
 	path = tools/sparse/sparse-src
 	url = git://git.kernel.org/pub/scm/devel/sparse/sparse.git
-[submodule "tools/runltp-ng"]
-	path = tools/runltp-ng
-	url = https://github.com/linux-test-project/runltp-ng.git
+[submodule "tools/kirk"]
+	path = tools/kirk
+	url = https://github.com/linux-test-project/kirk.git
diff --git a/tools/kirk b/tools/kirk
new file mode 160000
index 000000000..805c56c2a
--- /dev/null
+++ b/tools/kirk
@@ -0,0 +1 @@
+Subproject commit 805c56c2a69b2e9f24ba13f64eab1bdad5885678
diff --git a/tools/runltp-ng b/tools/runltp-ng
deleted file mode 160000
index e842511ed..000000000
--- a/tools/runltp-ng
+++ /dev/null
@@ -1 +0,0 @@
-Subproject commit e842511ed2c680e3b2ea6dec790913a41d5ed937
-- 
2.35.3


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH v1] Replace runltp-ng with kirk framework

[Cyril Hrubis]

Hi!
> Kirk application is a fork of runltp-ng and it aims to merge multiple
> Linux testing frameworks in one tool, providing support for remote
> testing via Qemu, SSH, LTX, parallel execution and much more.
> 
> Signed-off-by: Andrea Cervesato <andrea.cervesato@suse.com>
> ---
>  .gitmodules     | 6 +++---
>  tools/kirk      | 1 +
>  tools/runltp-ng | 1 -

Do we also want symlink from runltp-ng to kirk?

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH v1] Replace runltp-ng with kirk framework

[Petr Vorel]

Hi Cyril, Andrea,

> Hi!
> > Kirk application is a fork of runltp-ng and it aims to merge multiple
> > Linux testing frameworks in one tool, providing support for remote
> > testing via Qemu, SSH, LTX, parallel execution and much more.

> > Signed-off-by: Andrea Cervesato <andrea.cervesato@suse.com>
> > ---
> >  .gitmodules     | 6 +++---
> >  tools/kirk      | 1 +
> >  tools/runltp-ng | 1 -

> Do we also want symlink from runltp-ng to kirk?

+1

BTW I suggested Andrea in the beginning of kirk to have runltp-ng symlink,
which would behave like 'kirk --framework ltp'. I.e. this:

./kirk --framework ltp --run-suite syscalls

would be equivalent of

./runltp-ng --run-suite syscalls

Instead of having to run:
./runltp-ng --framework ltp --run-suite syscalls

In that case kirk would be a drop in replacement.
Andrea, would it be possible to implement this functionality?
(the default framework could be detected by symlink name, the same approach
busybox uses, more symlinks could be added).

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH v1] Replace runltp-ng with kirk framework

[Andrea Cervesato via ltp]

Hi,

On 9/15/23 13:19, Petr Vorel wrote:
> Hi Cyril, Andrea,
>
>> Hi!
>>> Kirk application is a fork of runltp-ng and it aims to merge multiple
>>> Linux testing frameworks in one tool, providing support for remote
>>> testing via Qemu, SSH, LTX, parallel execution and much more.
>>> Signed-off-by: Andrea Cervesato <andrea.cervesato@suse.com>
>>> ---
>>>   .gitmodules     | 6 +++---
>>>   tools/kirk      | 1 +
>>>   tools/runltp-ng | 1 -
>> Do we also want symlink from runltp-ng to kirk?
> +1
>
> BTW I suggested Andrea in the beginning of kirk to have runltp-ng symlink,
> which would behave like 'kirk --framework ltp'. I.e. this:
>
> ./kirk --framework ltp --run-suite syscalls
>
> would be equivalent of
>
> ./runltp-ng --run-suite syscalls
>
> Instead of having to run:
> ./runltp-ng --framework ltp --run-suite syscalls
>
> In that case kirk would be a drop in replacement.
> Andrea, would it be possible to implement this functionality?
> (the default framework could be detected by symlink name, the same approach
> busybox uses, more symlinks could be added).
>
> Kind regards,
> Petr

The default kirk behavior is to use '--framework ltp' by default, so 
there's no difference between

./kirk --framework ltp --run-suite syscalls

and

./kirk --run-suite syscalls

Regards,
Andrea


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH v1] Replace runltp-ng with kirk framework

[Petr Vorel]

> Hi,

> On 9/15/23 13:19, Petr Vorel wrote:
> > Hi Cyril, Andrea,

> > > Hi!
> > > > Kirk application is a fork of runltp-ng and it aims to merge multiple
> > > > Linux testing frameworks in one tool, providing support for remote
> > > > testing via Qemu, SSH, LTX, parallel execution and much more.
> > > > Signed-off-by: Andrea Cervesato <andrea.cervesato@suse.com>
> > > > ---
> > > >   .gitmodules     | 6 +++---
> > > >   tools/kirk      | 1 +
> > > >   tools/runltp-ng | 1 -
> > > Do we also want symlink from runltp-ng to kirk?
> > +1

> > BTW I suggested Andrea in the beginning of kirk to have runltp-ng symlink,
> > which would behave like 'kirk --framework ltp'. I.e. this:

> > ./kirk --framework ltp --run-suite syscalls

> > would be equivalent of

> > ./runltp-ng --run-suite syscalls

> > Instead of having to run:
> > ./runltp-ng --framework ltp --run-suite syscalls

> > In that case kirk would be a drop in replacement.
> > Andrea, would it be possible to implement this functionality?
> > (the default framework could be detected by symlink name, the same approach
> > busybox uses, more symlinks could be added).

> > Kind regards,
> > Petr

> The default kirk behavior is to use '--framework ltp' by default, so there's
> no difference between

> ./kirk --framework ltp --run-suite syscalls

> and

> ./kirk --run-suite syscalls

Great, then OK from my side. With adding the symlink:
Reviewed-by: Petr Vorel <pvorel@suse.cz>
(please send v2).

I'm for replacing runltp-ng with kirk before the release.
I guess Cyril will highlight it in the changelog and then we should replace all
files in the runltp-ng repo with simple README.md, which points to kirk git
repo.

I'd still recommend to implement the default framework functionality (kselftest
and liburing would benefit from it), but that can be added later.

Kind regards,
Petr

> Regards,
> Andrea


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp