From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 27BBAC46CA1 for ; Mon, 18 Sep 2023 09:38:25 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 5F0143CBEF5 for ; Mon, 18 Sep 2023 11:38:23 +0200 (CEST) Received: from in-6.smtp.seeweb.it (in-6.smtp.seeweb.it [IPv6:2001:4b78:1:20::6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 4846E3CBEE8 for ; Mon, 18 Sep 2023 11:38:11 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-6.smtp.seeweb.it (Postfix) with ESMTPS id DC683140E759 for ; Mon, 18 Sep 2023 11:38:10 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 3E58D1F892; Mon, 18 Sep 2023 09:38:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1695029890; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=haZgY0AEDkiKrh5ei34rlXAypbjF9zvGMpJr11x6m5w=; b=w+pfzLQLUbETebVg4VUD98nJGuZr/sLFDI2Jg1Uddl7n+rurrCNy1svfvN3x7Oc0HChUeM KLCQRyW/JJQCUQ6pkK/2T3rItdvLnvF5WqHYt21vazp5EgwAvvjYbRSfnqhL/IVP8VExuG HlntBpRW/R7ursHe1wCPsT+uKGwJ7po= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1695029890; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=haZgY0AEDkiKrh5ei34rlXAypbjF9zvGMpJr11x6m5w=; b=1s/R+lnGsam1h0O3Bk2mZNjj3JBi5mbEGaDSQZ7bAMW0tOxx1BLjpUmcTMBJlhYU1g0aq2 MaStEovCmM/+6iDg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2D1AC13480; Mon, 18 Sep 2023 09:38:10 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id /TkKCoIaCGVwHQAAMHmgww (envelope-from ); Mon, 18 Sep 2023 09:38:10 +0000 Date: Mon, 18 Sep 2023 11:38:54 +0200 From: Cyril Hrubis To: Petr Vorel Message-ID: References: <20230918082506.17464-1-andrea.cervesato@suse.de> <20230918082506.17464-3-andrea.cervesato@suse.de> <20230918091756.GB30304@pevik> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230918091756.GB30304@pevik> X-Virus-Scanned: clamav-milter 1.0.1 at in-6.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v3 2/2] Add Linux Test eXecutor inside tools X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! > This works, but why we don't use approach used for sparc, i.e. > > $(MAKE) -C ltx-src > > That way we would not have to redefine the default rules. Unfortunately this does not work well either because the ltx does not have install targed and trying to install a file from a subdirectory is not possible with the LTP build system. I've tried that and it didn't work. Let's merge this version that works, we can try to do make things better later on. > Also it detects missing git clone and runs > git submodule update --init if needed. > > I'm asking for a same approach, not only because later we can unify and reuse > the code in some make helper, but also because it'd be more user friendly if our > new git submodules work the same way. Now this needs to be discussed first. Currently the submodule is installed when user writes make check. That means that it's not triggered in default build and the default build works without network connection. I do not think that we should attempt to download additional repositories on default build. > But if there is not enough time before release I would not be against this. I'm would say that there is not enough time for a proper discussion, so I would really keep things as they are in the latest patchset and leave the discussion for later. -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp