From: Cyril Hrubis <chrubis@suse.cz>
To: Petr Vorel <pvorel@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 1/1] tst_fill_fs: Fix printf format error
Date: Mon, 18 Sep 2023 12:56:14 +0200 [thread overview]
Message-ID: <ZQgszt74aIR_wWDm@yuki> (raw)
In-Reply-To: <20230918102711.9567-1-pvorel@suse.cz>
Hi!
> openat() first parameter is file descriptor (int), not string.
> Add also original path (string) to be more informative.
>
> Fixes: df1b01cc1 ("tst_fill_fs: drop safe_macro from fill_flat_vec")
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
> ---
> I'd like to get this tiny fix merged before the release.
Yes please.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2023-09-18 10:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-18 10:27 [LTP] [PATCH 1/1] tst_fill_fs: Fix printf format error Petr Vorel
2023-09-18 10:56 ` Cyril Hrubis [this message]
2023-09-18 11:17 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQgszt74aIR_wWDm@yuki \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox