[LTP] [PATCH 1/1] tst_fill_fs: Fix printf format error

[LTP] [PATCH 1/1] tst_fill_fs: Fix printf format error

[Petr Vorel]

openat() first parameter is file descriptor (int), not string.
Add also original path (string) to be more informative.

Fixes: df1b01cc1 ("tst_fill_fs: drop safe_macro from fill_flat_vec")
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
I'd like to get this tiny fix merged before the release.

Kind regards,
Petr

 lib/tst_fill_fs.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/tst_fill_fs.c b/lib/tst_fill_fs.c
index 243eb279f..5e8cf9197 100644
--- a/lib/tst_fill_fs.c
+++ b/lib/tst_fill_fs.c
@@ -93,7 +93,8 @@ void fill_flat_vec(const char *path, int verbose)
 			tst_res(TINFO | TERRNO, "openat()");
 			return;
 		}
-		tst_brk(TBROK | TERRNO, "openat(%s, %d, 0600) failed", dir, O_PATH | O_DIRECTORY);
+		tst_brk(TBROK | TERRNO, "openat(%d, %d, 0600) failed for path %s",
+			dir, O_PATH | O_DIRECTORY, path);
 	}
 
 	SAFE_CLOSE(dir);
-- 
2.42.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH 1/1] tst_fill_fs: Fix printf format error

[Cyril Hrubis]

Hi!
> openat() first parameter is file descriptor (int), not string.
> Add also original path (string) to be more informative.
> 
> Fixes: df1b01cc1 ("tst_fill_fs: drop safe_macro from fill_flat_vec")
> Signed-off-by: Petr Vorel <pvorel@suse.cz>

Reviewed-by: Cyril Hrubis <chrubis@suse.cz>

> ---
> I'd like to get this tiny fix merged before the release.

Yes please.

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH 1/1] tst_fill_fs: Fix printf format error

[Petr Vorel]

Hi Cyril,

> Hi!
> > openat() first parameter is file descriptor (int), not string.
> > Add also original path (string) to be more informative.

> > Fixes: df1b01cc1 ("tst_fill_fs: drop safe_macro from fill_flat_vec")
> > Signed-off-by: Petr Vorel <pvorel@suse.cz>

> Reviewed-by: Cyril Hrubis <chrubis@suse.cz>

> > ---
> > I'd like to get this tiny fix merged before the release.

> Yes please.

Thanks for your review, merged.

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp