Re: [LTP] [PATCH v3] Add test for UI_GET_NAME ioctl

[Cyril Hrubis <chrubis@suse.cz>]

Hi!
> Fix:#573
> Signed-off-by: Wei Gao <wegao@suse.com>
> ---
>  testcases/kernel/input/input_helper.c | 21 ++++++++++++++++++++-
>  1 file changed, 20 insertions(+), 1 deletion(-)
> 
> diff --git a/testcases/kernel/input/input_helper.c b/testcases/kernel/input/input_helper.c
> index 09530fb4d..b9dc50a7f 100644
> --- a/testcases/kernel/input/input_helper.c
> +++ b/testcases/kernel/input/input_helper.c
> @@ -32,6 +32,7 @@
>  
>  static int uinput_loaded;
>  static int check_device(void);
> +static void check_ui_get_sysname_ioctl(int fd);

I do not think that this is needed, we do not call the function before
it's definition.

>  static int try_open_device(void)
>  {
> @@ -185,6 +186,22 @@ void send_rel_move(int fd, int x, int y)
>  	send_event(fd, EV_SYN, 0, 0);
>  }
>  
> +static void check_ui_get_sysname_ioctl(int fd)
> +{
> +	char sys_name[256];
> +	char dev_name[256];
> +	char *path;
> +
> +	SAFE_IOCTL(NULL, fd, UI_GET_SYSNAME(sizeof(sys_name)), sys_name, NULL);
> +	SAFE_ASPRINTF(NULL, &path, "/sys/devices/virtual/input/%s/name", sys_name);
> +	SAFE_FILE_SCANF(NULL, path, "%s", dev_name);

I would be inclined to use the FILE_SCANF() instead here and report
failure if the file does not exist or couldn't be read, something as:

	if (FILE_SCANF(NULL, path, "%s", dev_name)) {
		tst_res(TFAIL, "Failed to read name from the sysfs path");
		free(path);
		return;
	}

> +	if (strcmp(VIRTUAL_DEVICE, dev_name)) {
> +		tst_brkm(TBROK, NULL, "Unable to find the input device through ioctl");
> +	}

I do not think that tst_brkm() is the right here either, this is simple
TPASS/TFAIL situation. Can we just print TPASS/TFAIL based on if these
names match?

> +	free(path);
> +}
> +
>  void create_device(int fd)
>  {
>  	int nb;
> @@ -202,8 +219,10 @@ void create_device(int fd)
>  	SAFE_IOCTL(NULL, fd, UI_DEV_CREATE, NULL);
>  
>  	for (nb = 100; nb > 0; nb--) {
> -		if (check_device())
> +		if (check_device()) {
> +			check_ui_get_sysname_ioctl(fd);
>  			return;
> +		}
>  		usleep(10000);
>  	}
>  
> -- 
> 2.35.3
> 
> 
> -- 
> Mailing list info: https://lists.linux.it/listinfo/ltp

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp