* [LTP] [PATCH v1] Avoid swapon01 failing with EPERM
@ 2023-10-11 15:29 Marius Kittler
2023-10-11 15:43 ` Petr Vorel
2023-10-12 7:15 ` Cyril Hrubis
0 siblings, 2 replies; 4+ messages in thread
From: Marius Kittler @ 2023-10-11 15:29 UTC (permalink / raw)
To: ltp
* Simply require root permissions like the other swapon tests do
* Fixes #1091
Signed-off-by: Marius Kittler <mkittler@suse.de>
---
testcases/kernel/syscalls/swapon/swapon01.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/testcases/kernel/syscalls/swapon/swapon01.c b/testcases/kernel/syscalls/swapon/swapon01.c
index c334ae246..b5c3f359c 100644
--- a/testcases/kernel/syscalls/swapon/swapon01.c
+++ b/testcases/kernel/syscalls/swapon/swapon01.c
@@ -40,6 +40,7 @@ static void setup(void)
}
static struct tst_test test = {
+ .needs_root = 1,
.needs_tmpdir = 1,
.test_all = verify_swapon,
.setup = setup
--
2.42.0
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [LTP] [PATCH v1] Avoid swapon01 failing with EPERM
2023-10-11 15:29 [LTP] [PATCH v1] Avoid swapon01 failing with EPERM Marius Kittler
@ 2023-10-11 15:43 ` Petr Vorel
2023-10-12 7:15 ` Cyril Hrubis
1 sibling, 0 replies; 4+ messages in thread
From: Petr Vorel @ 2023-10-11 15:43 UTC (permalink / raw)
To: Marius Kittler; +Cc: ltp
> * Simply require root permissions like the other swapon tests do
> * Fixes #1091
Reported-by: Richard Palethorpe <rpalethorpe@suse.com>
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Suggested-by: Cyril Hrubis <chrubis@suse.cz>
Fixes: 23fa0e045 ("syscalls/swapon/swapon01: Convert swapon01 to the new API")
Fixes: https://github.com/linux-test-project/ltp/issues/1091
Thanks!
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [LTP] [PATCH v1] Avoid swapon01 failing with EPERM
2023-10-11 15:29 [LTP] [PATCH v1] Avoid swapon01 failing with EPERM Marius Kittler
2023-10-11 15:43 ` Petr Vorel
@ 2023-10-12 7:15 ` Cyril Hrubis
2023-10-12 7:34 ` Petr Vorel
1 sibling, 1 reply; 4+ messages in thread
From: Cyril Hrubis @ 2023-10-12 7:15 UTC (permalink / raw)
To: Marius Kittler; +Cc: ltp
Hi!
Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [LTP] [PATCH v1] Avoid swapon01 failing with EPERM
2023-10-12 7:15 ` Cyril Hrubis
@ 2023-10-12 7:34 ` Petr Vorel
0 siblings, 0 replies; 4+ messages in thread
From: Petr Vorel @ 2023-10-12 7:34 UTC (permalink / raw)
To: Marius Kittler; +Cc: ltp
Hi all,
thanks, merged!
very very nit: better to mark as this:
> * Fixes #1091
Fixes: #1091
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-10-12 7:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-11 15:29 [LTP] [PATCH v1] Avoid swapon01 failing with EPERM Marius Kittler
2023-10-11 15:43 ` Petr Vorel
2023-10-12 7:15 ` Cyril Hrubis
2023-10-12 7:34 ` Petr Vorel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox