From: Cyril Hrubis <chrubis@suse.cz>
To: Wei Gao <wegao@suse.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v1 1/2] lib: Add .ulimit
Date: Mon, 23 Oct 2023 14:32:38 +0200 [thread overview]
Message-ID: <ZTZn5vw-PFjKhYW9@yuki> (raw)
In-Reply-To: <ZTZnHLi1tSN_WGPc@yuki>
Hi!
> > +void tst_ulimit_conf(const struct tst_ulimit_val *conf)
> > +{
> > + struct rlimit rlim;
> > +
> > + rlim.rlim_cur = conf->rlim.rlim_cur;
> > + rlim.rlim_max = conf->rlim.rlim_max;
>
> I wonder if we should adjust the max only if it's smallre than the
> requested value.
Looking again we store both values in the structure. I wonder if we need
to set both, maybe we just need the rlim_cur value in the tst_ulimit_val
structure and we would attempt to adjust rlim_max only if its smaller
than rlim_cur. That would allow us to use the API even for tests that
does not require root to raise limits within the permitted maxium.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2023-10-23 12:32 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-21 12:29 [LTP] [PATCH v1 0/2] Lib add .ulimit setting Wei Gao via ltp
2023-10-21 12:29 ` [LTP] [PATCH v1 1/2] lib: Add .ulimit Wei Gao via ltp
2023-10-23 11:03 ` Petr Vorel
2023-10-23 12:29 ` Cyril Hrubis
2023-10-23 12:32 ` Cyril Hrubis [this message]
2023-10-21 12:29 ` [LTP] [PATCH v1 2/2] execl01.c: set stack to unlimited Wei Gao via ltp
2023-10-23 11:26 ` Petr Vorel
2023-10-25 8:37 ` [LTP] [PATCH v2 0/2] Lib add .ulimit setting Wei Gao via ltp
2023-10-25 8:37 ` [LTP] [PATCH v2 1/2] lib: Add .ulimit Wei Gao via ltp
2024-01-08 11:47 ` Petr Vorel
2023-10-25 8:37 ` [LTP] [PATCH v2 2/2] execl01.c: set stack to unlimited Wei Gao via ltp
2024-01-08 10:17 ` Petr Vorel
2024-01-09 6:59 ` [LTP] [PATCH v3 0/2] Lib add .ulimit setting Wei Gao via ltp
2024-01-09 6:59 ` [LTP] [PATCH v3 1/2] lib: Add .ulimit Wei Gao via ltp
2024-01-19 16:08 ` Cyril Hrubis
2024-01-23 7:57 ` Petr Vorel
2024-01-09 6:59 ` [LTP] [PATCH v3 2/2] execl01.c: set stack to unlimited Wei Gao via ltp
2024-01-19 16:09 ` Cyril Hrubis
2024-01-23 2:19 ` [LTP] [PATCH v4 0/2] Lib add .ulimit setting Wei Gao via ltp
2024-01-23 2:19 ` [LTP] [PATCH v4 1/2] lib: Add .ulimit Wei Gao via ltp
2024-01-23 8:36 ` Petr Vorel
2024-01-30 11:55 ` Petr Vorel
2024-01-23 2:19 ` [LTP] [PATCH v4 2/2] execl01.c: set stack to unlimited Wei Gao via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZTZn5vw-PFjKhYW9@yuki \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=wegao@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox