From: Cyril Hrubis <chrubis@suse.cz>
To: Marius Kittler <mkittler@suse.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v6 4/4] Use termios instead of legacy struct in ioctl02.c
Date: Mon, 23 Oct 2023 15:21:03 +0200 [thread overview]
Message-ID: <ZTZzP49bH8scNfI8@yuki> (raw)
In-Reply-To: <20230919110951.31500-5-mkittler@suse.de>
Hi!
We should actually test both, so ideally this test would have
.test_variants = 2 in the tst_test structure so that we can run it twice
both for old and new syscall. See for example
kernel/syscalls/brk/brk01.c for how the test_variants is used.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2023-10-23 13:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-19 11:09 [LTP] [PATCH v6 0/4] Improve ioctl02.c Marius Kittler
2023-09-19 11:09 ` [LTP] [PATCH v6 1/4] Refactor ioctl02.c to use the new test API Marius Kittler
2023-10-23 13:17 ` Cyril Hrubis
2023-09-19 11:09 ` [LTP] [PATCH v6 2/4] Make checks for termio flags more strict Marius Kittler
2023-09-19 11:09 ` [LTP] [PATCH v6 3/4] Remove disabled code in ioctl02.c Marius Kittler
2023-09-19 11:09 ` [LTP] [PATCH v6 4/4] Use termios instead of legacy struct " Marius Kittler
2023-10-23 13:21 ` Cyril Hrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZTZzP49bH8scNfI8@yuki \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=mkittler@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox