Re: [LTP] [PATCH 1/2] stack_clash: Guard functions used only in 64bit

[Cyril Hrubis <chrubis@suse.cz>]

Hi!
> To avoid "defined but not used" warnings when compiled on 32bit.
> 
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
>  testcases/cve/stack_clash.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/testcases/cve/stack_clash.c b/testcases/cve/stack_clash.c
> index 3a99c49bb..56b970a1b 100644
> --- a/testcases/cve/stack_clash.c
> +++ b/testcases/cve/stack_clash.c
> @@ -92,6 +92,7 @@ void segv_handler(int sig, siginfo_t *info, void *data LTP_ATTRIBUTE_UNUSED)
>  		_exit(EXIT_SUCCESS);
>  }
>  
> +#ifdef __x86_64__
>  static void force_bottom_up(void)
>  {
>  	FILE *fh;
> @@ -134,6 +135,7 @@ static void force_bottom_up(void)
>  out:
>  	SAFE_FCLOSE(fh);
>  }
> +#endif

Maybe I'm blind but this function does not seem to be called from inside
of #ifdef __x86_64__.

>  unsigned long read_stack_addr_from_proc(unsigned long *stack_size)
>  {
> @@ -187,6 +189,7 @@ void __attribute__((noinline)) preallocate_stack(unsigned long required)
>  	garbage[0] = garbage[required - 1] = '\0';
>  }
>  
> +#ifdef __x86_64__
>  static void do_mmap_placement_test(unsigned long stack_addr, unsigned long gap)
>  {
>  	void *map_test_gap;
> @@ -208,6 +211,7 @@ static void do_mmap_placement_test(unsigned long stack_addr, unsigned long gap)
>  		SAFE_MUNMAP(map_test_gap, MAPPED_LEN);
>  	}
>  }
> +#endif

This part looks good.

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp